doc: correct bitcoinconsensus_version in shared-libraries.md#15765
Merged
laanwj merged 1 commit intobitcoin:masterfrom Apr 9, 2019
Merged
doc: correct bitcoinconsensus_version in shared-libraries.md#15765laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
ACK 8ae6d02 |
Contributor
|
How about remove it entirely? |
Member
|
Nah, it's good to know what API version the file is documenting. Recently wrote a FUSE filesystem, and found it annoying that they had API changes after the library on my system, but there was no way to tell which API each version of the tutorial(s) were written for. |
Contributor
|
ACK 8ae6d02. |
Member
👍 |
laanwj
added a commit
that referenced
this pull request
Apr 9, 2019
…es.md 8ae6d02 doc: correct bitcoinconsensus_version in shared-libraries (fanquake) Pull request description: https://github.com/bitcoin/bitcoin/blob/efbc86733a551f2e1f5c43cd6de4fc730c7cce65/src/script/bitcoinconsensus.h#L36 ACKs for commit 8ae6d0: practicalswift: ACK 8ae6d02 promag: ACK 8ae6d02. Tree-SHA512: 48ba90afe02beaa0fc9c3baf24ab7477e7e36947abcf424dab515aaaf5be35b9df3af5a01fc2653f0216a83d9bbff6f1d48bb86131fa71c552798a2e73ffbd82
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 9, 2019
Github-Pull: bitcoin#15765 Rebased-From: 8ae6d02
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Apr 19, 2019
Github-Pull: bitcoin#15765 Rebased-From: 8ae6d02
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 5, 2020
Summary: Backport of Core [[bitcoin/bitcoin#15765 | PR15765]] Test Plan: Verify that `BITCOINCONSENSUS_API_VER` is 1 in `bitcoinconsensus.h` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bitcoin/src/script/bitcoinconsensus.h
Line 36 in efbc867