rpc: Remove dependency on interfaces::Chain in SignTransaction#15784
Conversation
|
Concept ACK. Thanks @ariard! |
ariard
force-pushed
the
2019-04-remove-chain-sign-tx-utility
branch
from
a6d7634 to
442a65b
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
src/rpc/rawtransaction_util.h
Outdated
There was a problem hiding this comment.
You should just be able to forward declare the Coin object and leave this include in the .cpp file if you change the coins argument into a reference.
(thanks to @ryanofsky for answering my question about this)
There was a problem hiding this comment.
Just forward declaration seems to do the job without gcc complaints
There was a problem hiding this comment.
Thanks. You should pass by reference anyway, otherwise this will make a copy of the entire map.
ariard
force-pushed
the
2019-04-remove-chain-sign-tx-utility
branch
from
442a65b to
b772cce
Compare
ariard
force-pushed
the
2019-04-remove-chain-sign-tx-utility
branch
from
b772cce to
0f4b200
Compare
|
Thanks, utACK 0f4b200 |
ariard
force-pushed
the
2019-04-remove-chain-sign-tx-utility
branch
from
0f4b200 to
70da741
Compare
|
Got this on travis failure : "Please manually re-run this job by using the travis restart button or asking a bitcoin maintainer to restart. The next run should not time out because the build cache has been saved." |
ariard
force-pushed
the
2019-04-remove-chain-sign-tx-utility
branch
from
70da741 to
c98aeb0
Compare
|
utACK c98aeb00c9eaeb12623dc8f6a644ee5f0044f3fa one you've removed that unnecessary |
Comment SignTransaction utility
ariard
force-pushed
the
2019-04-remove-chain-sign-tx-utility
branch
from
c98aeb0 to
99e88a3
Compare
|
99e88a3 removed unnecessary interfaces::Chain forward declaration |
|
utACK 99e88a3 |
|
utACK 99e88a3. |
| class CBasicKeyStore; | ||
| class UniValue; | ||
| struct CMutableTransaction; | ||
| class Coin; |
There was a problem hiding this comment.
Could sort these between CBasicKeyStore and UniValue above (I normally just pipe these lines to !sort in vim)
…saction 99e88a3 rpc: Remove dependency on interfaces::Chain in SignTransaction (Antoine Riard) Pull request description: Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp Obviously will need rebase after #15638 Tree-SHA512: 42ee8fcbcd38643bbd82210db6f68249bed5ee036a4c930a1db534d0469a133e287b8869c977bf0cc79a7296dde04f72adb74d24e1cd20f4a280f4c2b7fceb74
…ignTransaction 99e88a3 rpc: Remove dependency on interfaces::Chain in SignTransaction (Antoine Riard) Pull request description: Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp Obviously will need rebase after bitcoin#15638 Tree-SHA512: 42ee8fcbcd38643bbd82210db6f68249bed5ee036a4c930a1db534d0469a133e287b8869c977bf0cc79a7296dde04f72adb74d24e1cd20f4a280f4c2b7fceb74
…ransaction Summary: Comment SignTransaction utility bitcoin/bitcoin@99e88a3 --- Depends on D6257 Backport of Core [[bitcoin/bitcoin#15784 | PR15784]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D6258
7 participants
Assuming wallet RPCs and node RPCs will go into different processes, signrawtransactionwithkey doesn't need to access Coins via interfaces::Chain, it may use directly utility in node/coins.cpp
Obviously will need rebase after #15638