Skip to content

Doc: remove text about txes always relayed from -whitelist#15890

Merged
maflcko merged 1 commit intobitcoin:masterfrom
harding:2019-04-whitelist-help
May 8, 2019
Merged

Doc: remove text about txes always relayed from -whitelist#15890
maflcko merged 1 commit intobitcoin:masterfrom
harding:2019-04-whitelist-help

Conversation

@harding
Copy link
Contributor

@harding harding commented Apr 25, 2019

Updates text since -whitelistforcerelay was set to false by default in PR #15193.

@fanquake fanquake added the Docs label Apr 25, 2019
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 25, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15717 (Changes to support NAT-PMP by MishraShivendra)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko maflcko added this to the 0.18.1 milestone Apr 25, 2019
@sdaftuar
Copy link
Member

sdaftuar commented Apr 25, 2019

ACK. I actually had misremembered how this works myself, thinking that whitelistforcerelay only applied to the relay treatment of invalid transactions, rather than ones that might already be in the mempool.

Perhaps it would also be helpful to update the text for -whitelistforcerelay, to indicate that has to be set to true in order for transactions already in the mempool to be relayed as well? I guess that's a special case of "violate local relay policy", so maybe unnecessary.

@harding
Doc: remove text about txes always relayed from -whitelist
e0bb279 
Updates text since -whitelistforcerelay was set to false by default in
PR bitcoin#15193.
@harding harding force-pushed the 2019-04-whitelist-help branch from 305d1d7 to e0bb279 Compare April 25, 2019 17:12
@harding
Copy link
Contributor Author

harding commented Apr 25, 2019

Added details to -whitelistforcerelay about relaying already-in-mempool transactions, as suggested by @sdaftuar (thanks!).

@fanquake
Copy link
Member

fanquake commented May 8, 2019

utACK e0bb279

@maflcko
Copy link
Member

maflcko commented May 8, 2019

utACK e0bb279

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

utACK e0bb2799992afe88e6f4efc6d90ed82ddf1ec5ec
-----BEGIN PGP SIGNATURE-----

iQGyBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjt+Av4uSxr8JSYgJ3gYWycgdqe7PzhRMaCd+ws/hy/zXUeJHA8sGdSl87ouAp5
g07cj6wxrZewVFsaEDentt148YeuJ6L8Kf6ULULYpCgMXREcSFUvwZ6SbeXrGh6h
AkemZQTgg/d+0J0n+KYh3KvD6uOpnK/GjOtzsPcTGT0PlSSI6tboRKuCjaYpaAVh
psTrblgMSu/hKwUUINOozg63UHtfvBKjgrJCjNjcg49dqneLtYEQJYw40S+z9VRg
Eu6EKRIaBnK7Fwj/MVUxQamViv/uv66RRrLvK9bxzucChpGCFXe+Lr6i2Bnf+Bsx
1ZqQmFH4is2IwZOo0pw3Q1K/udWvGbcDHQk8wkVT/B+rDi7TA8LEk7N3sgFZ9ueU
5PAHcP/5kx9hCGyavRGRjG9TZqnKJ31hQ0bN2CWAk54UgbhL8U/fs+7DmwLjSy8X
6xYpZTGj5CYzSMAWQRbWuHqLgTeF6WUI1pTfs3P4hFVL9YiUMUIwI4KRMUiVhwvO
EsaGvkw=
=sRAF
-----END PGP SIGNATURE-----

Timestamp of file with hash 36a1c057321553005a3b0a003acc473e847ba59f808fe90604bafe115f9fa26a -

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request May 8, 2019
Merge bitcoin#15890: Doc: remove text about txes always relayed from …
08788ce 
…-whitelist

e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding)

Pull request description:

  Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193.

ACKs for commit e0bb27:
  fanquake:
    utACK e0bb279
  MarcoFalke:
    utACK e0bb279

Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
@maflcko maflcko merged commit e0bb279 into bitcoin:master May 8, 2019
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 10, 2019
@sidhujag
Merge bitcoin#15890: Doc: remove text about txes always relayed from …
d8de072 
…-whitelist

e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding)

Pull request description:

  Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193.

ACKs for commit e0bb27:
  fanquake:
    utACK e0bb279
  MarcoFalke:
    utACK e0bb279

Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request May 17, 2019
@harding
Doc: remove text about txes always relayed from -whitelist
eb85ee6 
Updates text since -whitelistforcerelay was set to false by default in
PR bitcoin#15193.

Github-Pull: bitcoin#15890
Rebased-From: e0bb279
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Aug 23, 2019
@harding
Doc: remove text about txes always relayed from -whitelist
0910ddd 
Updates text since -whitelistforcerelay was set to false by default in
PR bitcoin#15193.

Github-Pull: bitcoin#15890
Rebased-From: e0bb279
Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Aug 24, 2019
@harding @Bushstar
Doc: remove text about txes always relayed from -whitelist
3905266 
Updates text since -whitelistforcerelay was set to false by default in
PR bitcoin#15193.

Github-Pull: bitcoin#15890
Rebased-From: e0bb279
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Oct 19, 2020
@harding @PiRK
Doc: remove text about txes always relayed from -whitelist
3c35162 
Summary:
Updates text since -whitelistforcerelay was set to false by default in
[[bitcoin/bitcoin#15193 | PR15193]].

Backport of Core [[bitcoin/bitcoin#15890 | PR15890]]

Test Plan: `ninja && src/bitcoind -help`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D7975
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 1, 2021
@PastaPastaPasta
Merge bitcoin#15890: Doc: remove text about txes always relayed from …
1c53e32 
…-whitelist

e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding)

Pull request description:

  Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193.

ACKs for commit e0bb27:
  fanquake:
    utACK e0bb279
  MarcoFalke:
    utACK e0bb279

Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 11, 2021
@PastaPastaPasta
Merge bitcoin#15890: Doc: remove text about txes always relayed from …
6526309 
…-whitelist

e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding)

Pull request description:

  Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193.

ACKs for commit e0bb27:
  fanquake:
    utACK e0bb279
  MarcoFalke:
    utACK e0bb279

Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 12, 2021
@PastaPastaPasta
Merge bitcoin#15890: Doc: remove text about txes always relayed from …
27b75fb 
…-whitelist

e0bb279 Doc: remove text about txes always relayed from -whitelist (David A. Harding)

Pull request description:

  Updates text since -whitelistforcerelay was set to false by default in PR bitcoin#15193.

ACKs for commit e0bb27:
  fanquake:
    utACK e0bb279
  MarcoFalke:
    utACK e0bb279

Tree-SHA512: cf0c9321d72692d573039a04f8f1d048cbdf67ed86cc781523dabd3c45d2731b788f53749e6bb29d7da1ab44eb04030f352469b20489bb2a26c2c38fb61f6489
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

0.18.1

Development

Successfully merging this pull request may close these issues.

5 participants

@harding @DrahtBot @sdaftuar @fanquake @maflcko