Fix portability issue with pthreads#15968
Merged
laanwj merged 1 commit intobitcoin:masterfrom May 16, 2019
Merged
Conversation
This change resolves the following issue: bitcoin#15951 Only tested on OpenBSD 6.5/amd64
Member
|
tACK 1b05dff. Tested on OpenBSD6.4 ( Pre patch: CXX util/libbitcoin_util_a-rbf.o
CXX util/libbitcoin_util_a-threadnames.o
util/threadnames.cpp:26:5: error: use of undeclared identifier 'pthread_set_name_np'
pthread_set_name_np(pthread_self(), name);
^
1 error generated.
gmake[2]: *** [Makefile:8666: util/libbitcoin_util_a-threadnames.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....with this PR |
Member
|
utACK 1b05dff |
Contributor
|
Gitian builds for commit 3632143 (master):
Gitian builds for commit 1da169961518949bed9f1811e3d1345dedd4061a (master and this pull):
|
Contributor
Author
I agree that the most general way is best. I just followed the existing convention from https://github.com/bitcoin/bitcoin/blob/master/src/util/system.cpp : Is there anything else I need to do? |
Member
|
No, it's ok, going to merge this, sorry for the delay. |
laanwj
added a commit
that referenced
this pull request
May 16, 2019
1b05dff Fix portability issue with pthreads (grim-trigger) Pull request description: This change resolves the following issue: #15951 Only tested on OpenBSD 6.5/amd64 ACKs for commit 1b05df: fanquake: tACK 1b05dff. Tested on OpenBSD6.4 (`vagrant`). laanwj: utACK 1b05dff Tree-SHA512: af48581af32820d5adc9ae5abb44f8f1b592c323f86fe2484108b81629389f6ef347598f9a087aa6476ac553e59828cd7927bb4ab11dc70e7c9a944a92fc54ae
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 18, 2019
1b05dff Fix portability issue with pthreads (grim-trigger) Pull request description: This change resolves the following issue: bitcoin#15951 Only tested on OpenBSD 6.5/amd64 ACKs for commit 1b05df: fanquake: tACK 1b05dff. Tested on OpenBSD6.4 (`vagrant`). laanwj: utACK 1b05dff Tree-SHA512: af48581af32820d5adc9ae5abb44f8f1b592c323f86fe2484108b81629389f6ef347598f9a087aa6476ac553e59828cd7927bb4ab11dc70e7c9a944a92fc54ae
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 24, 2020
Summary: Fixes the build on some *BSD. Backport of core [[bitcoin/bitcoin#15968 | PR15968]]. Depends on D5540 (and D5542 for the test plan). Test Plan: ninja check Build on FreeBSD 12.0. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5541
ftrader
added a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Dec 1, 2020
Thread names in logs and deadlock debug tools See merge request bitcoin-cash-node/bitcoin-cash-node!834 This is a backport of [PR15849](bitcoin/bitcoin#15849) (Thread names in logs and deadlock debug tools). See original PR for benchmarks. Also includes some smaller follow-up PR's: * [PR15968](bitcoin/bitcoin#15968) - Fix portability issue with pthreads * [PR16984](bitcoin/bitcoin#16984) - util: Make thread names shorter * [PR17038](bitcoin/bitcoin#17038) - Don't rename main thread at process level ## Test plan New tests: `ninja check` Run with `-logthreadnames`, observe lines are prefixed with thread ``` 2020-10-28T11:39:16Z [init] init message: Done loading 2020-10-28T11:39:16Z [opencon] opencon thread start 2020-10-28T11:39:16Z [dnsseed] 0 addresses found from DNS seeds 2020-10-28T11:39:16Z [msghand] msghand thread start 2020-10-28T11:39:16Z [dnsseed] dnsseed thread exit ``` Compile with lockorder debugging enabled: `cmake -GNinja -DCMAKE_BUILD_TYPE=Debug ..`
linuxsh2
pushed a commit
to linuxsh2/dash
that referenced
this pull request
Aug 11, 2021
1b05dff Fix portability issue with pthreads (grim-trigger) Pull request description: This change resolves the following issue: bitcoin#15951 Only tested on OpenBSD 6.5/amd64 ACKs for commit 1b05df: fanquake: tACK 1b05dff. Tested on OpenBSD6.4 (`vagrant`). laanwj: utACK 1b05dff Tree-SHA512: af48581af32820d5adc9ae5abb44f8f1b592c323f86fe2484108b81629389f6ef347598f9a087aa6476ac553e59828cd7927bb4ab11dc70e7c9a944a92fc54ae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change resolves the following issue:
#15951
Only tested on OpenBSD 6.5/amd64