Skip to content

doc/lint: Fix spelling errors identified by codespell 1.15.0#16186

Merged
fanquake merged 1 commit intobitcoin:masterfrom
Empact:codespell-errors
Jun 16, 2019
Merged

doc/lint: Fix spelling errors identified by codespell 1.15.0#16186
fanquake merged 1 commit intobitcoin:masterfrom
Empact:codespell-errors

Conversation

@Empact
Copy link
Contributor

@Empact Empact commented Jun 11, 2019 •
edited
Loading

Note all changes are to comments / documentation.

After this commit, the only remaining output is:

  $ test/lint/lint-spelling.sh
  src/test/base32_tests.cpp:14: fo  ==> of, for
  src/test/base64_tests.cpp:14: fo  ==> of, for
  ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt

Note:

  • I ignore several valid alternative spellings , but changed homogenous
    to homogeneous as the latter is a more specific term according to the
    Google dictionary definitions I found
  • homogenous is present in tinyformat, hence should be addressed upstream
  • process' is correct only if there are plural processes

@Empact
Copy link
Contributor Author

Empact commented Jun 11, 2019

Output on master 6899ef3

$ test/lint/lint-spelling.sh 
.travis/lint_06_script.sh:23: keyserver  ==> key server
contrib/devtools/README.md:147: dowload  ==> download
doc/developer-notes.md:283: process'  ==> process's
src/cuckoocache.h:154: copyable  ==> copyable, copiable
src/net_processing.cpp:1867: Unparseable  ==> Unparsable
src/netaddress.cpp:242: addreses  ==> addresses
src/netaddress.cpp:290: addreses  ==> addresses
src/policy/fees.cpp:50: theses  ==> these, thesis, theses
src/primitives/transaction.h:195: wit  ==> wit, with
src/qt/addresstablemodel.h:44: Unparseable  ==> Unparsable
src/qt/paymentserver.cpp:721: errorString  ==> error string
src/qt/paymentserver.cpp:772: errorString  ==> error string
src/rpc/rawtransaction.cpp:42: overriden  ==> overridden
src/script/descriptor.cpp:37: unparseable  ==> unparsable
src/script/ismine.h:33: Cachable  ==> Cacheable
src/support/lockedpool.h:55: copyable  ==> copyable, copiable
src/support/lockedpool.h:166: copyable  ==> copyable, copiable
src/test/base32_tests.cpp:14: fo  ==> of, for
src/test/base64_tests.cpp:14: fo  ==> of, for
src/test/crypto_tests.cpp:570: trucated  ==> truncated
src/test/data/blockfilters.json:10: unparseable  ==> unparsable
src/test/data/script_tests.json:2: wit  ==> wit, with
src/test/script_tests.cpp:452: wit  ==> wit, with
src/test/script_tests.cpp:454: wit  ==> wit, with
src/test/script_tests.cpp:456: wit  ==> wit, with
src/test/script_tests.cpp:457: wit  ==> wit, with
src/test/script_tests.cpp:967: wit  ==> wit, with
src/test/script_tests.cpp:1534: wit  ==> wit, with
src/test/script_tests.cpp:1538: wit  ==> wit, with
src/test/script_tests.cpp:1557: wit  ==> wit, with
src/test/script_tests.cpp:1561: wit  ==> wit, with
src/test/script_tests.cpp:1580: wit  ==> wit, with
src/test/script_tests.cpp:1584: wit  ==> wit, with
src/test/script_tests.cpp:1603: wit  ==> wit, with
src/test/script_tests.cpp:1607: wit  ==> wit, with
src/test/script_tests.cpp:1626: wit  ==> wit, with
src/test/script_tests.cpp:1630: wit  ==> wit, with
src/test/script_tests.cpp:1649: wit  ==> wit, with
src/test/script_tests.cpp:1653: wit  ==> wit, with
src/tinyformat.h:493: homogenous  ==> homogeneous
src/torcontrol.cpp:415: fo  ==> of, for
test/functional/feature_nulldummy.py:92: wit  ==> wit, with
test/functional/feature_segwit.py:223: wit  ==> wit, with
test/functional/feature_segwit.py:233: wit  ==> wit, with
test/functional/feature_segwit.py:241: wit  ==> wit, with
test/functional/p2p_compactblocks.py:270: wit  ==> wit, with
test/functional/p2p_compactblocks.py:341: wit  ==> wit, with
test/functional/p2p_compactblocks.py:608: wit  ==> wit, with
test/functional/p2p_compactblocks.py:718: wit  ==> wit, with
test/functional/p2p_compactblocks.py:781: wit  ==> wit, with
test/functional/p2p_compactblocks.py:782: wit  ==> wit, with
test/functional/p2p_segwit.py:106: wit  ==> wit, with
test/functional/p2p_segwit.py:331: wit  ==> wit, with
test/functional/p2p_segwit.py:332: wit  ==> wit, with
test/functional/p2p_segwit.py:415: wit  ==> wit, with
test/functional/p2p_segwit.py:416: wit  ==> wit, with
test/functional/p2p_segwit.py:499: wit  ==> wit, with
test/functional/p2p_segwit.py:500: wit  ==> wit, with
test/functional/p2p_segwit.py:506: wit  ==> wit, with
test/functional/p2p_segwit.py:507: wit  ==> wit, with
test/functional/p2p_segwit.py:592: wit  ==> wit, with
test/functional/p2p_segwit.py:593: wit  ==> wit, with
test/functional/p2p_segwit.py:669: wit  ==> wit, with
test/functional/p2p_segwit.py:670: wit  ==> wit, with
test/functional/p2p_segwit.py:682: wit  ==> wit, with
test/functional/p2p_segwit.py:683: wit  ==> wit, with
test/functional/p2p_segwit.py:764: wit  ==> wit, with
test/functional/p2p_segwit.py:765: wit  ==> wit, with
test/functional/p2p_segwit.py:825: wit  ==> wit, with
test/functional/p2p_segwit.py:826: wit  ==> wit, with
test/functional/p2p_segwit.py:882: wit  ==> wit, with
test/functional/p2p_segwit.py:891: wit  ==> wit, with
test/functional/p2p_segwit.py:905: wit  ==> wit, with
test/functional/p2p_segwit.py:909: wit  ==> wit, with
test/functional/p2p_segwit.py:917: wit  ==> wit, with
test/functional/p2p_segwit.py:950: wit  ==> wit, with
test/functional/p2p_segwit.py:951: wit  ==> wit, with
test/functional/p2p_segwit.py:961: wit  ==> wit, with
test/functional/p2p_segwit.py:977: wit  ==> wit, with
test/functional/p2p_segwit.py:978: wit  ==> wit, with
test/functional/p2p_segwit.py:998: wit  ==> wit, with
test/functional/p2p_segwit.py:1005: wit  ==> wit, with
test/functional/p2p_segwit.py:1020: wit  ==> wit, with
test/functional/p2p_segwit.py:1041: wit  ==> wit, with
test/functional/p2p_segwit.py:1042: wit  ==> wit, with
test/functional/p2p_segwit.py:1050: wit  ==> wit, with
test/functional/p2p_segwit.py:1064: wit  ==> wit, with
test/functional/p2p_segwit.py:1065: wit  ==> wit, with
test/functional/p2p_segwit.py:1066: wit  ==> wit, with
test/functional/p2p_segwit.py:1077: wit  ==> wit, with
test/functional/p2p_segwit.py:1078: wit  ==> wit, with
test/functional/p2p_segwit.py:1117: wit  ==> wit, with
test/functional/p2p_segwit.py:1119: wit  ==> wit, with
test/functional/p2p_segwit.py:1126: wit  ==> wit, with
test/functional/p2p_segwit.py:1158: wit  ==> wit, with
test/functional/p2p_segwit.py:1159: wit  ==> wit, with
test/functional/p2p_segwit.py:1175: wit  ==> wit, with
test/functional/p2p_segwit.py:1211: wit  ==> wit, with
test/functional/p2p_segwit.py:1222: wit  ==> wit, with
test/functional/p2p_segwit.py:1233: wit  ==> wit, with
test/functional/p2p_segwit.py:1234: wit  ==> wit, with
test/functional/p2p_segwit.py:1241: wit  ==> wit, with
test/functional/p2p_segwit.py:1242: wit  ==> wit, with
test/functional/p2p_segwit.py:1249: wit  ==> wit, with
test/functional/p2p_segwit.py:1250: wit  ==> wit, with
test/functional/p2p_segwit.py:1251: wit  ==> wit, with
test/functional/p2p_segwit.py:1258: wit  ==> wit, with
test/functional/p2p_segwit.py:1281: wit  ==> wit, with
test/functional/p2p_segwit.py:1282: wit  ==> wit, with
test/functional/p2p_segwit.py:1307: wit  ==> wit, with
test/functional/p2p_segwit.py:1314: wit  ==> wit, with
test/functional/p2p_segwit.py:1325: wit  ==> wit, with
test/functional/p2p_segwit.py:1332: wit  ==> wit, with
test/functional/p2p_segwit.py:1409: wit  ==> wit, with
test/functional/p2p_segwit.py:1410: wit  ==> wit, with
test/functional/p2p_segwit.py:1423: wit  ==> wit, with
test/functional/p2p_segwit.py:1425: wit  ==> wit, with
test/functional/p2p_segwit.py:1458: wit  ==> wit, with
test/functional/p2p_segwit.py:1459: wit  ==> wit, with
test/functional/p2p_segwit.py:1518: wit  ==> wit, with
test/functional/p2p_segwit.py:1519: wit  ==> wit, with
test/functional/p2p_segwit.py:1539: wit  ==> wit, with
test/functional/p2p_segwit.py:1556: wit  ==> wit, with
test/functional/p2p_segwit.py:1615: wit  ==> wit, with
test/functional/p2p_segwit.py:1648: wit  ==> wit, with
test/functional/p2p_segwit.py:1673: wit  ==> wit, with
test/functional/p2p_segwit.py:1713: wit  ==> wit, with
test/functional/p2p_segwit.py:1731: wit  ==> wit, with
test/functional/p2p_segwit.py:1732: wit  ==> wit, with
test/functional/p2p_segwit.py:1753: wit  ==> wit, with
test/functional/p2p_segwit.py:1792: wit  ==> wit, with
test/functional/p2p_segwit.py:1793: wit  ==> wit, with
test/functional/p2p_segwit.py:1856: wit  ==> wit, with
test/functional/p2p_segwit.py:1862: wit  ==> wit, with
test/functional/p2p_segwit.py:1868: wit  ==> wit, with
test/functional/p2p_segwit.py:1874: wit  ==> wit, with
test/functional/p2p_segwit.py:1879: wit  ==> wit, with
test/functional/p2p_segwit.py:1883: wit  ==> wit, with
test/functional/p2p_segwit.py:1888: wit  ==> wit, with
test/functional/p2p_segwit.py:1894: wit  ==> wit, with
test/functional/p2p_segwit.py:1897: wit  ==> wit, with
test/functional/p2p_segwit.py:1900: wit  ==> wit, with
test/functional/p2p_segwit.py:1902: wit  ==> wit, with
test/functional/p2p_segwit.py:1905: wit  ==> wit, with
test/functional/p2p_segwit.py:1991: wit  ==> wit, with
test/functional/p2p_segwit.py:1992: wit  ==> wit, with
test/functional/p2p_segwit.py:1994: wit  ==> wit, with
test/functional/p2p_segwit.py:2008: wit  ==> wit, with
test/functional/p2p_segwit.py:2032: wit  ==> wit, with
test/functional/p2p_segwit.py:2033: wit  ==> wit, with
test/functional/p2p_segwit.py:2053: wit  ==> wit, with
test/functional/p2p_segwit.py:2055: wit  ==> wit, with
test/functional/p2p_segwit.py:2055: wit  ==> wit, with
test/functional/p2p_segwit.py:2056: wit  ==> wit, with
test/functional/p2p_segwit.py:2057: wit  ==> wit, with
test/functional/p2p_segwit.py:2058: wit  ==> wit, with
test/functional/test_framework/blocktools.py:83: wit  ==> wit, with
test/functional/test_framework/blocktools.py:84: wit  ==> wit, with
test/functional/test_framework/messages.py:417: wit  ==> wit, with
test/functional/test_framework/messages.py:424: wit  ==> wit, with
test/functional/test_framework/messages.py:435: wit  ==> wit, with
test/functional/test_framework/messages.py:435: wit  ==> wit, with
test/functional/test_framework/messages.py:451: wit  ==> wit, with
test/functional/test_framework/messages.py:452: wit  ==> wit, with
test/functional/test_framework/messages.py:454: wit  ==> wit, with
test/functional/test_framework/messages.py:470: wit  ==> wit, with
test/functional/test_framework/messages.py:481: wit  ==> wit, with
test/functional/test_framework/messages.py:483: wit  ==> wit, with
test/functional/test_framework/messages.py:483: wit  ==> wit, with
test/functional/test_framework/messages.py:484: wit  ==> wit, with
test/functional/test_framework/messages.py:485: wit  ==> wit, with
test/functional/test_framework/messages.py:486: wit  ==> wit, with
test/functional/test_framework/messages.py:520: wit  ==> wit, with
test/functional/test_framework/messages.py:521: wit  ==> wit, with
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt

@fanquake fanquake added the Docs label Jun 11, 2019
@promag
Copy link
Contributor

promag commented Jun 11, 2019

Should bump codespell on travis?

bitcoin/.travis/lint_04_install.sh

Line 9 in 6899ef3

travis_retry pip install codespell==1.13.0

@practicalswift
Copy link
Contributor

practicalswift commented Jun 11, 2019

ACK 8c7843fb9b52f865c84dcbb1603765593c6db56f, but please also bump codespell version on Travis :-)

maflcko
maflcko reviewed Jun 11, 2019
View reviewed changes
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not bump it in travis

@Empact
Fix spelling errors identified by codespell 1.15.0
b748bf6 
After this commit, the only remaining output is:

  $ test/lint/lint-spelling.sh
  src/test/base32_tests.cpp:14: fo  ==> of, for
  src/test/base64_tests.cpp:14: fo  ==> of, for
  ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt

Note:
* I ignore several valid alternative spellings
* homogenous is present in tinyformat, hence should be addressed upstream
* process' is correct only if there are plural processes
@Empact Empact force-pushed the codespell-errors branch from 8c7843f to b748bf6 Compare June 11, 2019 15:19
@Empact
Copy link
Contributor Author

Empact commented Jun 11, 2019 •
edited
Loading

Bumped on travis, removed tinyformat change.

@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 11, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #15257 (Scripts and tools: Bump flake8 to 3.7.7 by Empact)
  • #13728 (lint: Run the CI lint stage on mac by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@practicalswift
Copy link
Contributor

practicalswift commented Jun 11, 2019

ACK b748bf6

Nice cleanup!

fanquake
fanquake approved these changes Jun 16, 2019
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b748bf6

master (f6f9248):

test/lint/lint-spelling.sh 
.travis/lint_06_script.sh:23: keyserver  ==> key server
contrib/devtools/README.md:147: dowload  ==> download
doc/developer-notes.md:283: process'  ==> process's
src/cuckoocache.h:154: copyable  ==> copyable, copiable
src/net_processing.cpp:1889: Unparseable  ==> Unparsable
src/netaddress.cpp:242: addreses  ==> addresses
src/netaddress.cpp:290: addreses  ==> addresses
src/policy/fees.cpp:50: theses  ==> these, thesis, theses
src/primitives/transaction.h:195: wit  ==> wit, with
src/qt/addresstablemodel.h:44: Unparseable  ==> Unparsable
src/qt/paymentserver.cpp:721: errorString  ==> error string
src/qt/paymentserver.cpp:772: errorString  ==> error string
src/rpc/rawtransaction.cpp:42: overriden  ==> overridden
src/script/descriptor.cpp:37: unparseable  ==> unparsable
src/script/ismine.h:33: Cachable  ==> Cacheable
src/support/lockedpool.h:55: copyable  ==> copyable, copiable
src/support/lockedpool.h:166: copyable  ==> copyable, copiable
src/test/base32_tests.cpp:14: fo  ==> of, for
src/test/base64_tests.cpp:14: fo  ==> of, for
src/test/crypto_tests.cpp:570: trucated  ==> truncated
src/test/data/blockfilters.json:10: unparseable  ==> unparsable
src/test/data/script_tests.json:2: wit  ==> wit, with
src/test/script_tests.cpp:452: wit  ==> wit, with
src/test/script_tests.cpp:454: wit  ==> wit, with
src/test/script_tests.cpp:456: wit  ==> wit, with
src/test/script_tests.cpp:457: wit  ==> wit, with
src/test/script_tests.cpp:967: wit  ==> wit, with
src/test/script_tests.cpp:1534: wit  ==> wit, with
src/test/script_tests.cpp:1538: wit  ==> wit, with
src/test/script_tests.cpp:1557: wit  ==> wit, with
src/test/script_tests.cpp:1561: wit  ==> wit, with
src/test/script_tests.cpp:1580: wit  ==> wit, with
src/test/script_tests.cpp:1584: wit  ==> wit, with
src/test/script_tests.cpp:1603: wit  ==> wit, with
src/test/script_tests.cpp:1607: wit  ==> wit, with
src/test/script_tests.cpp:1626: wit  ==> wit, with
src/test/script_tests.cpp:1630: wit  ==> wit, with
src/test/script_tests.cpp:1649: wit  ==> wit, with
src/test/script_tests.cpp:1653: wit  ==> wit, with
src/tinyformat.h:493: homogenous  ==> homogeneous
src/torcontrol.cpp:415: fo  ==> of, for
test/functional/feature_nulldummy.py:92: wit  ==> wit, with
test/functional/feature_segwit.py:223: wit  ==> wit, with
test/functional/feature_segwit.py:233: wit  ==> wit, with
test/functional/feature_segwit.py:241: wit  ==> wit, with
test/functional/p2p_compactblocks.py:270: wit  ==> wit, with
test/functional/p2p_compactblocks.py:341: wit  ==> wit, with
test/functional/p2p_compactblocks.py:608: wit  ==> wit, with
test/functional/p2p_compactblocks.py:718: wit  ==> wit, with
test/functional/p2p_compactblocks.py:781: wit  ==> wit, with
test/functional/p2p_compactblocks.py:782: wit  ==> wit, with
test/functional/p2p_segwit.py:106: wit  ==> wit, with
test/functional/p2p_segwit.py:331: wit  ==> wit, with
test/functional/p2p_segwit.py:332: wit  ==> wit, with
test/functional/p2p_segwit.py:415: wit  ==> wit, with
test/functional/p2p_segwit.py:416: wit  ==> wit, with
test/functional/p2p_segwit.py:499: wit  ==> wit, with
test/functional/p2p_segwit.py:500: wit  ==> wit, with
test/functional/p2p_segwit.py:506: wit  ==> wit, with
test/functional/p2p_segwit.py:507: wit  ==> wit, with
test/functional/p2p_segwit.py:592: wit  ==> wit, with
test/functional/p2p_segwit.py:593: wit  ==> wit, with
test/functional/p2p_segwit.py:669: wit  ==> wit, with
test/functional/p2p_segwit.py:670: wit  ==> wit, with
test/functional/p2p_segwit.py:682: wit  ==> wit, with
test/functional/p2p_segwit.py:683: wit  ==> wit, with
test/functional/p2p_segwit.py:764: wit  ==> wit, with
test/functional/p2p_segwit.py:765: wit  ==> wit, with
test/functional/p2p_segwit.py:825: wit  ==> wit, with
test/functional/p2p_segwit.py:826: wit  ==> wit, with
test/functional/p2p_segwit.py:882: wit  ==> wit, with
test/functional/p2p_segwit.py:891: wit  ==> wit, with
test/functional/p2p_segwit.py:905: wit  ==> wit, with
test/functional/p2p_segwit.py:909: wit  ==> wit, with
test/functional/p2p_segwit.py:917: wit  ==> wit, with
test/functional/p2p_segwit.py:950: wit  ==> wit, with
test/functional/p2p_segwit.py:951: wit  ==> wit, with
test/functional/p2p_segwit.py:961: wit  ==> wit, with
test/functional/p2p_segwit.py:977: wit  ==> wit, with
test/functional/p2p_segwit.py:978: wit  ==> wit, with
test/functional/p2p_segwit.py:998: wit  ==> wit, with
test/functional/p2p_segwit.py:1005: wit  ==> wit, with
test/functional/p2p_segwit.py:1020: wit  ==> wit, with
test/functional/p2p_segwit.py:1041: wit  ==> wit, with
test/functional/p2p_segwit.py:1042: wit  ==> wit, with
test/functional/p2p_segwit.py:1050: wit  ==> wit, with
test/functional/p2p_segwit.py:1064: wit  ==> wit, with
test/functional/p2p_segwit.py:1065: wit  ==> wit, with
test/functional/p2p_segwit.py:1066: wit  ==> wit, with
test/functional/p2p_segwit.py:1077: wit  ==> wit, with
test/functional/p2p_segwit.py:1078: wit  ==> wit, with
test/functional/p2p_segwit.py:1117: wit  ==> wit, with
test/functional/p2p_segwit.py:1119: wit  ==> wit, with
test/functional/p2p_segwit.py:1126: wit  ==> wit, with
test/functional/p2p_segwit.py:1158: wit  ==> wit, with
test/functional/p2p_segwit.py:1159: wit  ==> wit, with
test/functional/p2p_segwit.py:1175: wit  ==> wit, with
test/functional/p2p_segwit.py:1211: wit  ==> wit, with
test/functional/p2p_segwit.py:1222: wit  ==> wit, with
test/functional/p2p_segwit.py:1233: wit  ==> wit, with
test/functional/p2p_segwit.py:1234: wit  ==> wit, with
test/functional/p2p_segwit.py:1241: wit  ==> wit, with
test/functional/p2p_segwit.py:1242: wit  ==> wit, with
test/functional/p2p_segwit.py:1249: wit  ==> wit, with
test/functional/p2p_segwit.py:1250: wit  ==> wit, with
test/functional/p2p_segwit.py:1251: wit  ==> wit, with
test/functional/p2p_segwit.py:1258: wit  ==> wit, with
test/functional/p2p_segwit.py:1281: wit  ==> wit, with
test/functional/p2p_segwit.py:1282: wit  ==> wit, with
test/functional/p2p_segwit.py:1307: wit  ==> wit, with
test/functional/p2p_segwit.py:1314: wit  ==> wit, with
test/functional/p2p_segwit.py:1325: wit  ==> wit, with
test/functional/p2p_segwit.py:1332: wit  ==> wit, with
test/functional/p2p_segwit.py:1409: wit  ==> wit, with
test/functional/p2p_segwit.py:1410: wit  ==> wit, with
test/functional/p2p_segwit.py:1423: wit  ==> wit, with
test/functional/p2p_segwit.py:1425: wit  ==> wit, with
test/functional/p2p_segwit.py:1458: wit  ==> wit, with
test/functional/p2p_segwit.py:1459: wit  ==> wit, with
test/functional/p2p_segwit.py:1518: wit  ==> wit, with
test/functional/p2p_segwit.py:1519: wit  ==> wit, with
test/functional/p2p_segwit.py:1539: wit  ==> wit, with
test/functional/p2p_segwit.py:1556: wit  ==> wit, with
test/functional/p2p_segwit.py:1615: wit  ==> wit, with
test/functional/p2p_segwit.py:1648: wit  ==> wit, with
test/functional/p2p_segwit.py:1673: wit  ==> wit, with
test/functional/p2p_segwit.py:1713: wit  ==> wit, with
test/functional/p2p_segwit.py:1731: wit  ==> wit, with
test/functional/p2p_segwit.py:1732: wit  ==> wit, with
test/functional/p2p_segwit.py:1753: wit  ==> wit, with
test/functional/p2p_segwit.py:1792: wit  ==> wit, with
test/functional/p2p_segwit.py:1793: wit  ==> wit, with
test/functional/p2p_segwit.py:1856: wit  ==> wit, with
test/functional/p2p_segwit.py:1862: wit  ==> wit, with
test/functional/p2p_segwit.py:1868: wit  ==> wit, with
test/functional/p2p_segwit.py:1874: wit  ==> wit, with
test/functional/p2p_segwit.py:1879: wit  ==> wit, with
test/functional/p2p_segwit.py:1883: wit  ==> wit, with
test/functional/p2p_segwit.py:1888: wit  ==> wit, with
test/functional/p2p_segwit.py:1894: wit  ==> wit, with
test/functional/p2p_segwit.py:1897: wit  ==> wit, with
test/functional/p2p_segwit.py:1900: wit  ==> wit, with
test/functional/p2p_segwit.py:1902: wit  ==> wit, with
test/functional/p2p_segwit.py:1905: wit  ==> wit, with
test/functional/p2p_segwit.py:1991: wit  ==> wit, with
test/functional/p2p_segwit.py:1992: wit  ==> wit, with
test/functional/p2p_segwit.py:1994: wit  ==> wit, with
test/functional/p2p_segwit.py:2008: wit  ==> wit, with
test/functional/p2p_segwit.py:2032: wit  ==> wit, with
test/functional/p2p_segwit.py:2033: wit  ==> wit, with
test/functional/p2p_segwit.py:2053: wit  ==> wit, with
test/functional/p2p_segwit.py:2055: wit  ==> wit, with
test/functional/p2p_segwit.py:2055: wit  ==> wit, with
test/functional/p2p_segwit.py:2056: wit  ==> wit, with
test/functional/p2p_segwit.py:2057: wit  ==> wit, with
test/functional/p2p_segwit.py:2058: wit  ==> wit, with
test/functional/test_framework/blocktools.py:83: wit  ==> wit, with
test/functional/test_framework/blocktools.py:84: wit  ==> wit, with
test/functional/test_framework/messages.py:417: wit  ==> wit, with
test/functional/test_framework/messages.py:424: wit  ==> wit, with
test/functional/test_framework/messages.py:435: wit  ==> wit, with
test/functional/test_framework/messages.py:435: wit  ==> wit, with
test/functional/test_framework/messages.py:451: wit  ==> wit, with
test/functional/test_framework/messages.py:452: wit  ==> wit, with
test/functional/test_framework/messages.py:454: wit  ==> wit, with
test/functional/test_framework/messages.py:470: wit  ==> wit, with
test/functional/test_framework/messages.py:481: wit  ==> wit, with
test/functional/test_framework/messages.py:483: wit  ==> wit, with
test/functional/test_framework/messages.py:483: wit  ==> wit, with
test/functional/test_framework/messages.py:484: wit  ==> wit, with
test/functional/test_framework/messages.py:485: wit  ==> wit, with
test/functional/test_framework/messages.py:486: wit  ==> wit, with
test/functional/test_framework/messages.py:520: wit  ==> wit, with
test/functional/test_framework/messages.py:521: wit  ==> wit, with
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt

This PR (b748bf6):

test/lint/lint-spelling.sh
src/test/base32_tests.cpp:14: fo  ==> of, for
src/test/base64_tests.cpp:14: fo  ==> of, for
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt

@fanquake fanquake merged commit b748bf6 into bitcoin:master Jun 16, 2019
fanquake added a commit that referenced this pull request Jun 16, 2019
@fanquake
Merge #16186: doc/lint: Fix spelling errors identified by codespell 1…
47d981e 
….15.0

b748bf6 Fix spelling errors identified by codespell 1.15.0 (Ben Woosley)

Pull request description:

  Note all changes are to comments / documentation.

  After this commit, the only remaining output is:

  ```
    $ test/lint/lint-spelling.sh
    src/test/base32_tests.cpp:14: fo  ==> of, for
    src/test/base64_tests.cpp:14: fo  ==> of, for
    ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt
  ```

  Note:
  * I ignore several valid alternative spellings ~, but changed homogenous
  to homogeneous as the latter is a more specific term according to the
  Google dictionary definitions I found~
  * homogenous is present in tinyformat, hence should be addressed upstream
  * process' is correct only if there are plural processes

ACKs for commit b748bf:
  practicalswift:
    ACK b748bf6
  fanquake:
    ACK b748bf6

Tree-SHA512: 9add7044643ce015e0a44d8b27a3f300d72c485ffff550fb6491a17f14528085289ec5caddfe02f291ea9b2cded38a0dd3079652a054e2d7fe2ff4f7b53db5d7
@Empact Empact deleted the codespell-errors branch June 22, 2019 04:02
@hebasto hebasto mentioned this pull request Nov 2, 2019
Merged
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Sep 10, 2021
@fanquake @UdjinM6
Merge bitcoin#16186: doc/lint: Fix spelling errors identified by code…
c261311 
…spell 1.15.0

b748bf6 Fix spelling errors identified by codespell 1.15.0 (Ben Woosley)

Pull request description:

  Note all changes are to comments / documentation.

  After this commit, the only remaining output is:

  ```
    $ test/lint/lint-spelling.sh
    src/test/base32_tests.cpp:14: fo  ==> of, for
    src/test/base64_tests.cpp:14: fo  ==> of, for
    ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt
  ```

  Note:
  * I ignore several valid alternative spellings ~, but changed homogenous
  to homogeneous as the latter is a more specific term according to the
  Google dictionary definitions I found~
  * homogenous is present in tinyformat, hence should be addressed upstream
  * process' is correct only if there are plural processes

ACKs for commit b748bf:
  practicalswift:
    ACK b748bf6
  fanquake:
    ACK bitcoin@b748bf6

Tree-SHA512: 9add7044643ce015e0a44d8b27a3f300d72c485ffff550fb6491a17f14528085289ec5caddfe02f291ea9b2cded38a0dd3079652a054e2d7fe2ff4f7b53db5d7
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Oct 5, 2021
@fanquake @UdjinM6
Merge bitcoin#16186: doc/lint: Fix spelling errors identified by code…
53b2f81 
…spell 1.15.0

b748bf6 Fix spelling errors identified by codespell 1.15.0 (Ben Woosley)

Pull request description:

  Note all changes are to comments / documentation.

  After this commit, the only remaining output is:

  ```
    $ test/lint/lint-spelling.sh
    src/test/base32_tests.cpp:14: fo  ==> of, for
    src/test/base64_tests.cpp:14: fo  ==> of, for
    ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt
  ```

  Note:
  * I ignore several valid alternative spellings ~, but changed homogenous
  to homogeneous as the latter is a more specific term according to the
  Google dictionary definitions I found~
  * homogenous is present in tinyformat, hence should be addressed upstream
  * process' is correct only if there are plural processes

ACKs for commit b748bf:
  practicalswift:
    ACK b748bf6
  fanquake:
    ACK bitcoin@b748bf6

Tree-SHA512: 9add7044643ce015e0a44d8b27a3f300d72c485ffff550fb6491a17f14528085289ec5caddfe02f291ea9b2cded38a0dd3079652a054e2d7fe2ff4f7b53db5d7
pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021
@fanquake @pravblockc
Merge bitcoin#16186: doc/lint: Fix spelling errors identified by code…
a504e65 
…spell 1.15.0

b748bf6 Fix spelling errors identified by codespell 1.15.0 (Ben Woosley)

Pull request description:

  Note all changes are to comments / documentation.

  After this commit, the only remaining output is:

  ```
    $ test/lint/lint-spelling.sh
    src/test/base32_tests.cpp:14: fo  ==> of, for
    src/test/base64_tests.cpp:14: fo  ==> of, for
    ^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt
  ```

  Note:
  * I ignore several valid alternative spellings ~, but changed homogenous
  to homogeneous as the latter is a more specific term according to the
  Google dictionary definitions I found~
  * homogenous is present in tinyformat, hence should be addressed upstream
  * process' is correct only if there are plural processes

ACKs for commit b748bf:
  practicalswift:
    ACK b748bf6
  fanquake:
    ACK bitcoin@b748bf6

Tree-SHA512: 9add7044643ce015e0a44d8b27a3f300d72c485ffff550fb6491a17f14528085289ec5caddfe02f291ea9b2cded38a0dd3079652a054e2d7fe2ff4f7b53db5d7
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fanquake fanquake fanquake approved these changes

+1 more reviewer

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Empact @promag @practicalswift @DrahtBot @fanquake @maflcko