wallet_resendwallettransaction.py: fix coinbase height#16292
wallet_resendwallettransaction.py: fix coinbase height#16292instagibbs wants to merge 1 commit intobitcoin:masterfrom
Conversation
|
From BIP34:
So I think current code is correct? |
|
@promag you're making the next block, so no it's not. FWIW We have bip34 active on Elements functional tests which is how I ran into this. |
|
@instagibbs I've just thought of this case: if |
|
(assuming it's the same result as it's literally just |
|
Actually ACK eb3c8de. |
|
@instagibbs prefer #16292? |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
closing in favor of #16325 |
|
Thanks, I am also working on activating BIP34 earlier in regtest ⌛ |
|
I'm ~certain someone wrote a PR to do that already, but I cannot find it. |
fab0c82 rpc: Clarify that block count means height excl genesis (MarcoFalke) Pull request description: There is a common misconception that the block count returned by the blockchain rpcs includes the genesis block. See for example the discussion in #16292 (comment). However, it really returns the height, which is `0` for the genesis block. So clarify that and also remove the misleading "longest blockchain" comment. Finally, fix the wallet test that incorrectly used this rpc. ACKs for top commit: instagibbs: utACK fab0c82 promag: ACK fab0c82, sorry for the misconception. Tree-SHA512: 0d087cbb628d3866352bca6420402f392e6a997e579941701a408a7fca355d84645045661f39b022e4479cc07f85a6cddaa9095b6fd9911b245692482420a5e4
fab0c82 rpc: Clarify that block count means height excl genesis (MarcoFalke) Pull request description: There is a common misconception that the block count returned by the blockchain rpcs includes the genesis block. See for example the discussion in bitcoin/bitcoin#16292 (comment). However, it really returns the height, which is `0` for the genesis block. So clarify that and also remove the misleading "longest blockchain" comment. Finally, fix the wallet test that incorrectly used this rpc. ACKs for top commit: instagibbs: utACK bitcoin/bitcoin@fab0c82 promag: ACK fab0c82, sorry for the misconception. Tree-SHA512: 0d087cbb628d3866352bca6420402f392e6a997e579941701a408a7fca355d84645045661f39b022e4479cc07f85a6cddaa9095b6fd9911b245692482420a5e4
4 participants
Coinbase height is yet to be enforced on regtest, which allows these little errors in.