Introducing the ScriptPubKeyMan (short for ScriptPubKeyManager) for managing scriptPubKeys and their associated scripts and keys. This functionality is moved over from CWallet. Instead, CWallet will have a pointer to a ScriptPubKeyMan for every possible address type, internal and external. It will fetch the correct ScriptPubKeyMan as necessary. When fetching new addresses, it chooses the ScriptPubKeyMan based on address type and whether it is change. For signing, it takes the script and asks each ScriptPubKeyMan for whether that ScriptPubKeyMan considers that script IsMine, whether it has that script, or whether it is able to produce a signature for it. If so, the ScriptPubKeyMan will provide a SigningProvider to the caller which will use that in order to sign.

There is currently one ScriptPubKeyMan - the LegacyScriptPubKeyMan. Each CWallet will have only one LegacyScriptPubKeyMan with the pointers for all of the address types and change pointing to this LegacyScriptPubKeyMan. It is created when the wallet is loaded and all keys and metadata are loaded into it instead of CWallet. The LegacyScriptPubKeyMan is primarily made up of all of the key and script management that used to be in CWallet. For convenience, CWallet has a GetLegacyScriptPubKeyMan which will return the LegacyScriptPubKeyMan or a nullptr if it does not have one (not yet implemented, but callers will check for the nullptr). For purposes of signing, LegacyScriptPubKeyMan's GetSigningProvider will return itself rather than a separate SigningProvider. This will be different for future ScriptPubKeyMans.

The LegacyScriptPubKeyMan will also handle the importing and exporting of keys and scripts instead of CWallet. As such, a number of RPCs have been limited to work only if a LegacyScriptPubKeyMan can be retrieved from the wallet. These RPCs are sethdseed, addmultisigaddress, importaddress, importprivkey, importpubkey, importmulti, dumpprivkey, and dumpwallet. Other RPCs which relied on the wallet for scripts and keys have been modified in order to take the SigningProvider retrieved from the ScriptPubKeyMan for a given script.

Overall, these changes should not effect how everything actually works and the user should experience no difference between having this change and not having it. As such, no functional tests were changed, and the only unit tests changed were those that were directly accessing CWallet functions that have been removed.

This PR is the last step in the Wallet Structure Changes.

The commits are organized as follows:

• Miscellaneous changes that don't necessarily make sense outside of this PR
  • Move wallet enums to walletutil.h
  • List output types in an array in order to be iterated over
  • Always try to sign for all pubkeys in multisig
• Interface definitions and miscellaneous changes in preparation for ScriptPubKeyMan integration
  • Introduce both ScriptPubKeyMan as an interface and LegacyScriptPubKeyMan as a dummy class
  • Add LegacyScriptPubKeyMan to CWallet
  • Add function callbacks for wallet flags and versions and wallet database
  • Fetch the SigningProvider for a script from the wallet
  • Fetch the ScriptPubKeyMan for given output type and internal-ness, or a given script, or ScriptPubKeyMan id
• Implementation of LegacyScriptPubKeyMan by copying existing code from CWallet. These will pass all tests and do not affect CWallet
  • Implement GetSigningProvider in LegacyScriptPubKeyMan
  • Implement function to connect ScriptPubKeyMan's NotifyCanGetAddessesChanged and NotifyWatchOnlyChanged to CWallet's
  • Implement IsLocked and IsCrypted in LegacyScriptPubKeyMan
  • Implement LoadCryptedKey and AddCryptedKey in LegacyScriptPubKeyMan
  • Implement UpdateTimeFirstKey, and GetTimeFirstKey in LegacyScriptPubKeyMan
  • Implement AddWatchOnly, RemoveWatchOnly, HaveWatchOnly, and LoadWatchOnly in LegacyScriptPubKeyMan
  • Implement AddKeyPubKey and LoadKey in LegacyScriptPubKeyMan
  • Implement WalletLogPrintf in LegacyScriptPubKeyMan
  • Implement SetHDCHain, and IsHDEnabled in LegacyScriptPubKeyMan
  • Implement LoadCScript in LegacyScriptPubKeyMan
  • Implement LoadKeyMetadata and LoadScriptMetadata in LegacyScriptPubKeyMan
  • Implement GetKey, HaveKey, and GetPubKey in LegacyScriptPubKeyMan
  • Implement GenerateNewKey in LegacyScriptPubKeyMan
  • Implement LoadKeyPool in LegacyScriptPubKeyMan
  • Implement GetOldestKeyPoolTime, KeypoolCountExternalKeys, and GetKeypoolSize in LegacyScriptPubKeyMan
  • Implement CanGetAddresses, CanGenerateKeys, and HavePrivateKeys in LegacyScriptPubKeyMan
  • Implement GenerateNewSeed, DeriveNewSeed, and SetHDSeed for LegacyScriptPubKeyMan
  • Implement TopUpKeypool, TopUp, and NewKeyPool in LegacyScriptPubKeyMan
  • Implement ReturnAddress, and KeepKey in LegacyScriptPubKeyMan
  • Implement GetNewAddress, and GetReservedAddress in LegacyScriptPubKeyMan
  • Implement MarkUnusedAddresses in LegacyScriptPubKeyMan
  • Implement IsMine in LegacyScriptPubKeyMan
  • Implement UpgradeKeyMetaData, SetupGeneration, IsFirstRun, Upgrade, RewriteDB in LegacyScriptPubKeyMan
  • Implement Unlock, Lock, and Encrypt and LegacyScriptPubKeyMan
  • Implement ImporScripts, ImportPrivKeys, ImportPubKeys, and ImportScriptPubKeys in LegacyScriptPubKeyMan
  • Implement GetMetadata in LegacyScriptPubKeyMan
  • Implement GetKeyOrigin in LegacyScriptPubKeyMan
  • Implement actually loading everything into LegacyScriptPubKeyMan
  • Implement CanProvide in LegacyScriptPubKeyMan
• Replacing CWallet functions and RPC things with calls to ScriptPubKeyMan or LegacyScriptPubKeyMan. These will compile but are not expected to pass tests hence the [ci skip].
  • [ci skip] Remove CWallet from IsMine and have CWallet always use ScriptPubKeyMan's IsMine
  • [ci skip] moveonly: move ismine stuff to be a module of LegacyScriptPubKeyMan
  • [ci skip] Have GetNewAddress, GetNewChangeAddress, and ReserveAddress use ScriptPubKeyMan
  • [ci skip] Mark used addresses in ScriptPubKeyMan
  • [ci skip] Call UpgradeKeyMetaData for each ScriptPubKeyMan
  • [ci skip] Sign using SigningProvider from ScriptPubKeyMan when signing within CWallet
  • [ci skip] Do not allow import*, dump*, and addmultisigaddress RPCs when wallet is not backed by LegacyScriptPubKeyMan
  • [ci skip] Change Imports to use LegacyScriptPubKeyMan Imports
  • [ci skip] Use SigningProviders and ScriptPubKeyMans in listunspent, signmessage, signrawtransactionwithwallet, and getaddressinfo
  • [ci skip] Use LegacyScriptPubKeyMan in addmultisigaddress and sethdseed
  • [ci skip] Use LegacyScriptPubKeyMan for hdseedid in getwalletinfo
  • [ci skip] Change KeypoolCountExternal and GetKeypoolSize to get aggregate sizes from ScriptPubKeyMans
  • [ci skip] Have IsHDEnabled fetch from ScriptPubKeyMans
  • [ci skip] Fetch oldest keypool time from ScriptPubKeyMans
  • [ci skip] have TopUpKeyPool call TopUp in each ScriptPubKeyMan
  • [ci skip] Have EncryptWallet, Lock, and Unlock call their respective functions in ScriptPubKeyMans
  • [ci skip] Use LegacyScriptPubKeyMan throughout psbt_wallet_tests
  • [ci skip] Use LegacyScriptPubKeyMan throughout wallettool
  • [ci skip] Use ScriptPubKeyMans' Setup and Upgrade functions when loading or creating a wallet
  • [ci skip] Define first run as having no ScriptPubKeyMans
  • [ci skip] Use RewriteDB action when DB needs rewrite
  • [ci skip] Use GetTimeFirstKey instead of nTimeFirstKey
  • [ci skip] Use LegacyScriptPubKeyMan for in wallet_tests
  • [ci skip] Use LegacyScriptPubKeyMan in dumpprivkey and dumpwallet
  • [ci skip] Change CanGetAddresses to fetch from ScriptPubKeyMan
  • [ci skip] Fetch the correct SigningProvider for signing PSBTs
  • [ci skip] Use LegacyScriptPubKeyMan in test util
  • [ci skip] Use LegacyScriptPubKeyMan in some parts of getbalances and createwallet
  • [ci skip] Have getPubKey and getPrivKey use SigningProvider
  • [ci skip] Use LegacyScriptPubKeyMan in benchmarks involving the wallet
  • [ci skip] Store p2sh scripts in AddAndGetDestinationForScript
• Tying everything together and removing the CWallet functions.
  • Remove unused functions and switch CWallet to use ScriptPubKeyMan