test: Rework ci (Use travis only as fallback env)#16582
test: Rework ci (Use travis only as fallback env)#16582maflcko merged 5 commits intobitcoin:masterfrom
Conversation
|
@MarcoFalke Could you provide some additional context? With this PR merged tests would still run in both Appveyor and Travis, right? What is the plan? :-) |
|
The plan is to be flexible, to be able to switch away from travis any time without much hassle. Also, this makes it easier to run the ci locally. |
3c99346 to
d6230c8
Compare
|
Concept ACK. |
2dfc5d8 to
472aadb
Compare
faf7c0a to
fa88a5f
Compare
|
Fixed typo in doc and added a note on how to run the ci locally |
4e0c757 to
f1a0571
Compare
|
I'm now seeing an error running this: |
|
It says |
|
Specifically The ci is generally assuming the the folder is a fresh git clone. If needed, that can be changed later on, but better not part of this pull. |
Shouldn't that all be handled by the script? If not, then some docs about why you can't run the tests twice in a row would be handy. |
|
Done |
fanquake
left a comment
There was a problem hiding this comment.
Thanks ACK fa9404d76d16c618dbd2c19973246900918f9e6c - Maybe @sipsorcery or @NicolasDorier might also want to test here, then we'd have all OS's covered?
|
I don't think docker on windows can run Ubuntu containers |
| Needs rebase |
|
Rebased without any changes due to overly sensitive merge conflict detection on GitHub. git range-diff should be empty: |
faeacf3 ci: Add note that this assumes a fresh git clone (MarcoFalke) fa6cbdc ci: Use ./ci/ on non-travis host (MarcoFalke) fa31bc3 ci: Remove dependence on travis, use it as fallback env (MarcoFalke) fa0aac0 ci: Add retry (MarcoFalke) fafe78f ci: Rename .travis/ to ./ci/ (MarcoFalke) Pull request description: This moves the `.travis` folder to `ci` and removes dependence on travis, so that the test script can be run anywhere. Top commit has no ACKs. Tree-SHA512: 4d8c82f3eb4e9e047444b0e0f700485e929a3c4d27fc8777a95b8847f23ed507d2701cc92730198b14d1e753cbb558ffac883da558fc2ec72b8a12c4eaec9000
It can since https://docs.docker.com/docker-for-windows/wsl-tech-preview/ Actually it was already possible to use ubuntu docker containers on Windows but now it possible directly on top of the Windows Subsystem for Linux kernel. |
@fanquake I looked over the PR and successfully ran my appveyor build with the PR merged. Doesn't seem to be anything Windows related in this PR? Ony travis and shell scripts. Or did you testing the script changes with the WSL/Mingw builds on Windows? |
|
Thanks @sipsorcery. I also thought it was possible to run on Windows.
Yea I just meant checking out this PR, and testing/running the scripts, to make sure they were working in your Windows development setups. |
This moves the
.travisfolder tociand removes dependence on travis, so that the test script can be run anywhere.