build: remove mingw linker workaround from win gitian descriptor#16667
build: remove mingw linker workaround from win gitian descriptor#16667maflcko merged 1 commit intobitcoin:masterfrom
Conversation
|
Fails with |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (bitcoin#6900). However, it should no longer be required, as we have switched to Bionic (bitcoin#13171), and that has a far newer version of binutils. binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192
ac85e81 to
bd3f5a9
Compare
|
Gitian builds for commit 13377b7 (master):
Gitian builds for commit 2cfaf8bbd8d0a5a42ed8c0762aff98b3ebf6f155 (master and this pull):
|
|
Performing a Gitian build on bd3f5a9 right now if anyone wants to compare. |
|
Eh? DrahtBot did a build on 2cfaf8b and it didn't even start. (Or for some other reason didn't produce a |
|
Aw sorry 🤦♂️. Looks like this time it worked. |
|
What is the status of this? |
|
ACK bd3f5a9 Show signature and timestampSignature: Timestamp of file with hash |
|
Ok, I am confused. For commit 7b2a788d911e5c3f5aeb36dba5a03827428e800b (master+this pull) it failed:
|
|
Also fails for commit bd3f5a9 |
|
@MarcoFalke Here are my results for bd3f5a9 |
|
Which virtualization are you using (lxc, kvm, podman, docker, bare metal, ...)? |
|
Also, how many compile threads and is the result stable for you? |
|
Here's what I used: I'll try it again to see if result is stable! |
|
Everything important seems to match except the |
|
Thanks, I'll debug some more maybe tomorrow |
…itian descriptor bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake) Pull request description: This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (bitcoin#6900). However, it should no longer be required, as we have switched to Bionic (bitcoin#13171) and that has a far newer version of binutils. Original discussion: bitcoin#6900 binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192 ACKs for top commit: MarcoFalke: ACK bd3f5a9 theuni: ACK bd3f5a9 laanwj: ACK bd3f5a9 Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c
This commit removes the directory that has not been used since bitcoin#16667.
This commit removes the directory that is no longer used since bitcoin#16667.
This commit removes the directory that is no longer used since bitcoin#16667.
This commit removes the directory that is no longer used since bitcoin#16667.
This commit removes the directory that is no longer used since bitcoin#16667. Github-Pull: bitcoin#18556 Rebased-From: 2aa48ed
…scriptors a7dbb27 build: add missing attributes to Win installer (Fuzzbawls) 13d0b48 nsis: Don't duplicate URL string (Fuzzbawls) 56563e5 build: remove WINDOWS_BITS from build system (fanquake) 0cb37c8 nsis: Write to correct filename in first place (Carl Dong) 7aa2823 gitian: Put things in the right place to begin with (Carl Dong) 0dcf6e6 gitian: Eliminate rename dependency (Carl Dong) ba579b9 gitian: Smaller diff with gitian-linux.yml (Carl Dong) 3b9d5e8 gitian: Fix README inclusion in archives (Carl Dong) 07c27d2 gitian: Use split-debug.sh for Win builds (Carl Dong) 9f19095 build: Add README.md to DIST target (MarcoFalke) ce80c76 build: remove mingw linker workaround from win gitian descriptor (fanquake) 37441b0 scripted-diff: gitian: Use REFERENCE_DATETIME directly. (Fuzzbawls) 966fe9a depends: remove usage of TAR_OPTIONS (fanquake) 12fd641 build: remove export GZIP from gitian descriptors (fanquake) Pull request description: This is a collection of upstream PRs focused on cleaning up the gitian descriptors (un-needed or duplicate code bits, standardizing similar actions across the descriptors, etc), and minor cleanups to supporting build system files. Included are the following upstream PRs: * bitcoin#16141 * bitcoin#16184 * bitcoin#16667 * bitcoin#17097 * bitcoin#17029 * bitcoin#17308 * bitcoin#17756 * bitcoin#18059 ACKs for top commit: furszy: Tested ACK a7dbb27 random-zebra: ACK a7dbb27 and merging... Tree-SHA512: 409d4f51adfb1c90aa8bc572fe6610596dea1293a8ca795f9071bb88bd583bd7678359ee19e34440bb0d117075ebd27f9a622247ee3dfd0cd9088e6da306a4d5
This commit removes the directory that is no longer used since bitcoin#16667.
…itian descriptor bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake) Pull request description: This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (dashpay#6900). However, it should no longer be required, as we have switched to Bionic (bitcoin#13171) and that has a far newer version of binutils. Original discussion: bitcoin#6900 binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192 ACKs for top commit: MarcoFalke: ACK bd3f5a9 theuni: ACK bd3f5a9 laanwj: ACK bd3f5a9 Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c
…itian descriptor bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake) Pull request description: This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (dashpay#6900). However, it should no longer be required, as we have switched to Bionic (bitcoin#13171) and that has a far newer version of binutils. Original discussion: bitcoin#6900 binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192 ACKs for top commit: MarcoFalke: ACK bd3f5a9 theuni: ACK bd3f5a9 laanwj: ACK bd3f5a9 Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c
…itian descriptor bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake) Pull request description: This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (dashpay#6900). However, it should no longer be required, as we have switched to Bionic (bitcoin#13171) and that has a far newer version of binutils. Original discussion: bitcoin#6900 binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192 ACKs for top commit: MarcoFalke: ACK bd3f5a9 theuni: ACK bd3f5a9 laanwj: ACK bd3f5a9 Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c
Summary: > This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (#6900). > However, it should no longer be required, as we have switched to Bionic (#13171), and that > has a far newer version of binutils. > > binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192 Bitcoin ABC now uses Debian Buster, which has an even more recent version of binutils (2.31 vs 2.30). This is a backport of [[bitcoin/bitcoin#16667 | core#16667]] Depends on D10584 Test Plan: @bot gitian-win Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D10587
This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (#6900).
However, it should no longer be required, as we have switched to Bionic (#13171) and that
has a far newer version of binutils.
Original discussion: #6900
binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192