test: Check for codespell in lint-spelling.sh#16767
Merged
fanquake merged 1 commit intobitcoin:masterfrom Aug 31, 2019
Merged
Conversation
Similar check for spellcheck already exists in lint-shell.sh
Contributor
|
ACK 8340763 -- diff looks correct |
fanquake
approved these changes
Aug 31, 2019
Member
fanquake
left a comment
fanquake
left a comment
There was a problem hiding this comment.
ACK 8340763 - Test is the same as in lint-shell.sh.
git rev-parse HEAD
8340763dc3278c828ee7d525de4c71b4615d17cc
michaels-MacBook-Pro-2:bitcoin michael$ test/lint/lint-spelling.sh
ci/retry/retry:20: Paramters ==> Parameters
contrib/guix/manifest.scm:109: Convienience ==> Convenience
src/netbase.cpp:608: thru ==> through
src/netbase.cpp:712: sepcified ==> specified
src/node/transaction.cpp:34: doesnt ==> doesn't, does not
src/node/transaction.cpp:34: doesnt' ==> doesn't
src/test/base32_tests.cpp:14: fo ==> of, for
src/test/base64_tests.cpp:14: fo ==> of, for
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt
michaels-MacBook-Pro-2:bitcoin michael$ pip uninstall codespell
Uninstalling codespell-1.15.0:
Would remove:
/Users/michael/.pyenv/versions/3.5.6/bin/codespell
/Users/michael/.pyenv/versions/3.5.6/lib/python3.5/site-packages/codespell-1.15.0-py3.5.egg-info
/Users/michael/.pyenv/versions/3.5.6/lib/python3.5/site-packages/codespell_lib/*
Proceed (y/n)? y
Successfully uninstalled codespell-1.15.0
michaels-MacBook-Pro-2:bitcoin michael$ test/lint/lint-spelling.sh
Skipping spell check linting since codespell is not installed.
fanquake
added a commit
that referenced
this pull request
Aug 31, 2019
8340763 Check for codespell in lint-spelling.sh (Kristaps Kaupe) Pull request description: Similar check for `spellcheck` already exists in `lint-shell.sh` ACKs for top commit: practicalswift: ACK 8340763 -- diff looks correct fanquake: ACK 8340763 - Test is the same as in `lint-shell.sh`. Tree-SHA512: f590fc4eae391c5246e86cb70cf79431bd3763ac872f82d3b2222c3a095235ca046a7072c5e61bbaeb3ed6ecd5ff85979769ee8b585de4fb97ac8cfbbf73b956
linuxsh2
pushed a commit
to linuxsh2/dash
that referenced
this pull request
Aug 11, 2021
8340763 Check for codespell in lint-spelling.sh (Kristaps Kaupe) Pull request description: Similar check for `spellcheck` already exists in `lint-shell.sh` ACKs for top commit: practicalswift: ACK 8340763 -- diff looks correct fanquake: ACK 8340763 - Test is the same as in `lint-shell.sh`. Tree-SHA512: f590fc4eae391c5246e86cb70cf79431bd3763ac872f82d3b2222c3a095235ca046a7072c5e61bbaeb3ed6ecd5ff85979769ee8b585de4fb97ac8cfbbf73b956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar check for
spellcheckalready exists inlint-shell.sh