Chainparams: Wallet: Decouple DefaultFallbackfee() from IsTestChain()#16771
Closed
jtimon wants to merge 1 commit intobitcoin:masterfrom
Closed
Chainparams: Wallet: Decouple DefaultFallbackfee() from IsTestChain()#16771jtimon wants to merge 1 commit intobitcoin:masterfrom
jtimon wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
jtimon
force-pushed
the
b19-chainparams-fallbackfee
branch
from
b233533 to
e7865a8
Compare
jtimon
force-pushed
the
b19-chainparams-fallbackfee
branch
from
e7865a8 to
46c835f
Compare
Contributor
Author
|
Closing since competing #16524 was merged instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't change functionality beyond improving the --help tdocumentation.
Together with #16770 , this allows to get rid of Params().IsTestChain().
This is an alternative to #16524 , which, for example @instagibbs doesn't seem to like very much.