doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util#16900
Merged
fanquake merged 1 commit intobitcoin:masterfrom Sep 20, 2019
Merged
doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util#16900fanquake merged 1 commit intobitcoin:masterfrom
fanquake merged 1 commit intobitcoin:masterfrom
Conversation
Member
|
ACK fae8be06e7d54f70514cd5fa43423f79c2779e12 |
maflcko
force-pushed
the
1909-docRpcUtil
branch
from
fae8be0 to
fa8d65f
Compare
Member
Author
|
Addressed feedback by @promag |
Contributor
|
ACK fa8d65f -- const correctness is good and diff looks correct |
fanquake
approved these changes
Sep 20, 2019
fanquake
added a commit
that referenced
this pull request
Sep 20, 2019
…transaction_util fa8d65f doc: Fix doxygen comment for SignTransaction in rpc/rawtransaction_util (MarcoFalke) Pull request description: The param `coins` to `SignTransaction` is final and can thus not be extended (as suggested by the doc). ACKs for top commit: practicalswift: ACK fa8d65f -- const correctness is good and diff looks correct fanquake: ACK fa8d65f Tree-SHA512: 041e159f2c3cf96e296173c31f3e5f35bbc7711cc888aa4bf08aaa8c65c95ee7f7672f65396690a9af45795a618eea0fadde7fb02d29ec85f1b4df5e6d9e0c7a
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 22, 2020
Summary: The param coins to SignTransaction is final and can thus not be extended (as suggested by the doc). This was changed in [[bitcoin/bitcoin#16798 | PR16798]] where ParsePrevouts was extracted from SignTransaction. This is a backport of Core [[bitcoin/bitcoin#16900 | PR16900]] Test Plan: `ninja && ninja check` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8053
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The param
coinstoSignTransactionis final and can thus not be extended (as suggested by the doc).