This fixes it, but the stupid linters don't like it:

test/functional/test_framework/messages.py:46: unused variable 'NODE_GETUTXO' (60% confidence)

Can I just get rid of the linter, or is there another approach that would be preferred?

You could add to test/lint/lint-python-dead-code-whitelist?

There, got linter happy.

ACK 78487ef

That was quite an interesting chain of coincidences and fails; the fact that the tested servicesflags (0x809) didn't contain any hexadecimal symbols a-f covered the wrong base for the hexstring-to-integer conversion, which in turn was covered by a too weak assertion policy in assert_net_servicesnames(), also allowing more names in the list than just the ones represented in the flags. An additional assertion bin(servicesflags).count('1') == len(servicesnames) would have also solved the problem, but the PR approach, getting rid of all the if statements, is more generic and flexible.

I wouldn't be surprised if other users also stepped into this trap. The field should probably be a normal json number, not a hex encoded string version of the int.

Concept ACK anyway

Yes, agree it should be a Number ideally.

unsigned ACK 78487ef (looked at the diff on GitHub)

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #16961 (test: Remove python dead code linter by laanwj)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Closing in favor of #16991