gui: Change sendcoins dialogue Yes to Send#16964
Merged
maflcko merged 1 commit intobitcoin:masterfrom Oct 2, 2019
Merged
Conversation
Contributor
|
ACK |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Concept ACK |
Member
fanquake
changed the title
Member
Member
|
Note that bump fee uses the same dialog. |
Member
|
Definitely better. We don't have a translation for bare "Send" yet, so this has to go in after the 0.19 split. |
maflcko
pushed a commit
that referenced
this pull request
Oct 2, 2019
a649cc6 Change sendcoins dialogue Yes to Send (Gregory Sanders) Pull request description: It's more self-explanatory, matches "cancel" better, and makes future extensions such as #16944 more directly understandable to the user. ACKs for top commit: Sjors: Trivial code review ACK a649cc6. I also used Send in #16966 (`ui - make send a wizard`) laanwj: ACK a649cc6 jonatack: Code review ACK a649cc6 Tree-SHA512: fe4993bc7ac653d28f3d399ade046bcfd405511aec06ff041bb5aef47e0736faf3e3112a6db660cd761af56392dc6b97f2c2341ed3eff4490079c5eb8a0d465a
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 2, 2019
a649cc6 Change sendcoins dialogue Yes to Send (Gregory Sanders) Pull request description: It's more self-explanatory, matches "cancel" better, and makes future extensions such as bitcoin#16944 more directly understandable to the user. ACKs for top commit: Sjors: Trivial code review ACK a649cc6. I also used Send in bitcoin#16966 (`ui - make send a wizard`) laanwj: ACK a649cc6 jonatack: Code review ACK a649cc6 Tree-SHA512: fe4993bc7ac653d28f3d399ade046bcfd405511aec06ff041bb5aef47e0736faf3e3112a6db660cd761af56392dc6b97f2c2341ed3eff4490079c5eb8a0d465a
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Nov 15, 2019
Github-Pull: bitcoin#16964 Rebased-From: a649cc6
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Nov 17, 2019
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 1, 2020
Summary: Change sendcoins dialogue Yes to Send (Gregory Sanders) Pull request description: It's more self-explanatory, matches "cancel" better, and makes future extensions such as bitcoin/bitcoin#16944 more directly understandable to the user. bitcoin/bitcoin@a649cc6 --- Backport of Core [[bitcoin/bitcoin#16964 | PR16964]] Test Plan: ninja ./src/qt/bitcoin-qt -regtest send myself money, see 'Send' instead of 'Yes' Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7292
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
a649cc6 Change sendcoins dialogue Yes to Send (Gregory Sanders) Pull request description: It's more self-explanatory, matches "cancel" better, and makes future extensions such as bitcoin#16944 more directly understandable to the user. ACKs for top commit: Sjors: Trivial code review ACK a649cc6. I also used Send in bitcoin#16966 (`ui - make send a wizard`) laanwj: ACK a649cc6 jonatack: Code review ACK a649cc6 Tree-SHA512: fe4993bc7ac653d28f3d399ade046bcfd405511aec06ff041bb5aef47e0736faf3e3112a6db660cd761af56392dc6b97f2c2341ed3eff4490079c5eb8a0d465a
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 13, 2021
a649cc6 Change sendcoins dialogue Yes to Send (Gregory Sanders) Pull request description: It's more self-explanatory, matches "cancel" better, and makes future extensions such as bitcoin#16944 more directly understandable to the user. ACKs for top commit: Sjors: Trivial code review ACK a649cc6. I also used Send in bitcoin#16966 (`ui - make send a wizard`) laanwj: ACK a649cc6 jonatack: Code review ACK a649cc6 Tree-SHA512: fe4993bc7ac653d28f3d399ade046bcfd405511aec06ff041bb5aef47e0736faf3e3112a6db660cd761af56392dc6b97f2c2341ed3eff4490079c5eb8a0d465a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's more self-explanatory, matches "cancel" better, and makes future extensions such as #16944 more directly understandable to the user.