Conversation
|
ACK bcdab14673fd421fe3441980a0e50cce087420c2 |
Yes, but whether to put it under BIP9 or the affected deployment BIPs? |
|
It could be appended to each deployment, similar to how ab0c35a did it. |
laanwj
force-pushed
the
2019_09_bips_v19
branch
from
4513d3b to
c43b99f
Compare
laanwj
force-pushed
the
2019_09_bips_v19
branch
from
c43b99f to
4cadf01
Compare
|
|
|
A few potential improvements:
|
doc/bips.md
Outdated
There was a problem hiding this comment.
No strong opinion, but the fact that BIP 9 was responsible for their activation might be controversial. See e.g. https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2019-August/017267.html
doc/bips.md
Outdated
There was a problem hiding this comment.
bip 34 was buried in bip 90 (a different pull request). See e.g #9879
There was a problem hiding this comment.
OK, will revert that change.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
laanwj
force-pushed
the
2019_09_bips_v19
branch
from
4cadf01 to
b11514d
Compare
|
I've removed the commit about the BIP 9 deployments, will leave writing that to someone else. Edit: @Sjors thanks, added. |
|
ACK 82c1177 |
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
Concept ACK.
In the first line
BIPs that are implemented by Bitcoin Core (up-to-date up to **v0.18.0**):
s/18/19/
Might want to mention the version bump in the release process? https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md#before-every-major-and-minor-release |
|
ACK 60e855f |
60e855f doc: Bump version in bips.md, mention bumping in release process (Wladimir J. van der Laan) 82c1177 doc: Add mention of BIP158 indexing since v0.19.0 (Wladimir J. van der Laan) 2267006 doc: Add mention of BIP125 used by wallet GUI by default since v0.18.1 (Wladimir J. van der Laan) b11514d doc: Add mention of BIP70 disabling by default in bips.md (Wladimir J. van der Laan) Pull request description: - Add mention of BIP70 disabling by default at build time. Any others? E.g. does the burying of deployments of #16060 need to be mentioned? If so, where and how? For all of BIPs 34, 65 and 66? ACKs for top commit: hebasto: ACK 60e855f Tree-SHA512: 76aac3118bb9b56eeea75d046a55d8678a4c5c43004bec98a653f285ef59c34e67af01b0af3ddcefe4e92d37eea89f4f6627e4d056194f54e2e6168c79b4865c
60e855f doc: Bump version in bips.md, mention bumping in release process (Wladimir J. van der Laan) 82c1177 doc: Add mention of BIP158 indexing since v0.19.0 (Wladimir J. van der Laan) 2267006 doc: Add mention of BIP125 used by wallet GUI by default since v0.18.1 (Wladimir J. van der Laan) b11514d doc: Add mention of BIP70 disabling by default in bips.md (Wladimir J. van der Laan) Pull request description: - Add mention of BIP70 disabling by default at build time. Any others? E.g. does the burying of deployments of bitcoin#16060 need to be mentioned? If so, where and how? For all of BIPs 34, 65 and 66? ACKs for top commit: hebasto: ACK 60e855f Tree-SHA512: 76aac3118bb9b56eeea75d046a55d8678a4c5c43004bec98a653f285ef59c34e67af01b0af3ddcefe4e92d37eea89f4f6627e4d056194f54e2e6168c79b4865c
5 participants
Any others?
E.g. does the burying of deployments of #16060 need to be mentioned? If so, where and how? For all of BIPs 34, 65 and 66?