[BIP 174] PSBT version, proprietary, and xpub fields#17034
[BIP 174] PSBT version, proprietary, and xpub fields#17034laanwj merged 15 commits intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
src/psbt.h
Outdated
There was a problem hiding this comment.
Manually inspected that all the fields with constant types are now being written with compact size, but I would like to be more systematic somehow in the future.
achow101
force-pushed
the
bip174-extensions
branch
2 times, most recently
from
9ca1f8b to
674e638
Compare
achow101
force-pushed
the
bip174-extensions
branch
from
674e638 to
dd1a5ca
Compare
achow101
force-pushed
the
bip174-extensions
branch
from
dd1a5ca to
7fbaf8b
Compare
achow101
force-pushed
the
bip174-extensions
branch
from
7fbaf8b to
7795804
Compare
achow101
force-pushed
the
bip174-extensions
branch
from
7795804 to
19200a7
Compare
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
ACK 7f066240654608743eee165149f7036f43791922
Here is a rebase: https://github.com/darosior/bitcoin/tree/bip174-extensions .
I also have a branch implementing the various hash preimage input types, since it is needed for Miniscript signing support. Here it is rebased on this one since i figured it might make sense to have other input types implementations in this PR as well.
achow101
force-pushed
the
bip174-extensions
branch
from
7f06624 to
a5aa690
Compare
achow101
force-pushed
the
bip174-extensions
branch
2 times, most recently
from
fd20409 to
198b080
Compare
achow101
force-pushed
the
bip174-extensions
branch
from
198b080 to
e75e52f
Compare
|
re-utACK e75e52f7a2a82e24b20f59255cf39809342fcf58 |
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
re-ACK e75e52f7a2a82e24b20f59255cf39809342fcf58
…to psbt module SerializeToVector, UnserializeFromVector, DeserializeHDKeypaths, and SerializeHDKeypaths were in sign.h where PSBT was originally implemented. Since all of the PSBT serialization has moved to its own file, these functions should follow.
CExtPubKey does not store the version bytes for the extended public key. We store these so that a CExtPubKey can be serialized and deserialized with the same version bytes.
|
Code review ACK 8152117 |
9 participants
Implements the changes to BIP 174 proposed in bitcoin/bips#849 and bitcoin/bips#784
Implements
PSBT_GLOBAL_VERSION,PSBT_GLOBAL_PROPRIETARY,PSBT_IN_PROPRIETARY,PSBT_OUT_PROPRIETARY, andPSBT_GLOBAL_XPUB. ThePSBT_GLOBAL_XPUBchanges are merged in from #16463.Also includes the test vectors added to BIP 174 for these fields.
A number of additional changes to keypath and xpub serialization are made to support
PSBT_GLOBAL_XPUB.