Skip to content

tests: Add fuzzing harness for descriptor Span-parsing helpers#17113

Merged
maflcko merged 1 commit intobitcoin:masterfrom
practicalswift:fuzzers-spanparsing
Oct 16, 2019
Merged

tests: Add fuzzing harness for descriptor Span-parsing helpers#17113
maflcko merged 1 commit intobitcoin:masterfrom
practicalswift:fuzzers-spanparsing

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented Oct 12, 2019

Add fuzzing harness for descriptor Span-parsing helpers (spanparsing).

As suggested by a fuzz testing enthusiast in #16887 (comment).

Testing this PR

Run:

$ CC=clang CXX=clang++ ./configure --enable-fuzz \
      --with-sanitizers=address,fuzzer,undefined
$ make
$ src/test/fuzz/spanparsing

@fanquake fanquake added the Tests label Oct 12, 2019
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 12, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #17051 (tests: Add deserialization fuzzing harnesses by practicalswift)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0e2585875764d1c120043f0e9a3a499b0079726b only, did not look at the other commits

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK 0e2585875764d1c120043f0e9a3a499b0079726b only, did not look at the other commits
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjAeAwAr9NgrYNFJbdZmonusrCxHskWSxI5FNPfveSJeSEoltttDv46rvXU2MOF
FCQ0WS8vaUHV/9t/5R8AmTGvB91I5q/YkVd/6dCL3TTupiDQS25ofHy5a09D+2xi
XE69KSQ7hNkS9IvEjaO5xhcYumh+Q5ZZQQjDgwvKvNbX72F5YBXZc6sAg4Iz+9/L
ke/7bVIshN3ixSe0qEPWctx6Kmp64sBq0CPGLGiH368wXtQcy07bpzMAndJXjBhD
rjl/kM7oPzp+JXVa64+rOIHpDKWHx06ckTR1z/7+Ju2St8SIHzQq1NGjYcPhR5RO
/C/4NQBVeHklYZSyGjjSddEcCR2a+rirzIOTIUab5jqKPH7XMEGBaPUVMyhS5j9g
lyTPMYzJOreTi9oW/WwwA2DM5xWqVJO9+jtEXZft6r9Yecux0+/uElAzzytn1YwN
7Ty/HTNJNQ7pgKrGauxZEQ3uPZkMgVKJhYxzCcE3HWYV7P8rQd+s/aGmM5Xw3Dk0
r3odoobi
=/nL5
-----END PGP SIGNATURE-----

Timestamp of file with hash 31bdd75e9fd947f3bb361daae0a144d145e489f6aad21993c7234511eac4cd3c -

@maflcko
Copy link
Member

maflcko commented Oct 16, 2019

re-ACK 58d67f1

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

re-ACK 58d67f1cc068c3779e309dc8a82ce33158c3e5b2
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUg2Egv+KUb4p7VLHGldLjeIDnRdqtEyeElris8BshOqJgMQ6XrG7qDB95V4Iovo
DelsfaqBuD+MKVXQyhqsNGeVvfll2INfvjGKkg23Qa9TloAFkTXiMLMrDS/H0I8S
lPbUpIwucfr4Ge5v950KDK8xK/7y4Odxo5+FjF9L6dYKixfJ6LuM9LJRbBJ3VfiX
xbf4NRA88s/iA9cb0/2dQlpQvYE4zmZeVSagLhbNxLQ0EoKTA/NIXiBr56ipl9Mv
rv9HOCBmg2crmLkFiszscdxgiY0ODgC3kLJGiDaiQN+6Jg2WgGrVBTEKW40TEi3k
MsVvyQymri+oom7qxU+5wW5MWjqnVw0K/RXql9ebQbUOuNVf3pb03e44zW+PwuNd
hGB9ryniVTG04ga3jNz9yj3Ti99S7WyuF01xqqc25KVX6NUKIndOsfCPpV0NvFfO
YKt675F6/C8ciXRrmzwUwL5nSy6ghA2HWqnBoim8KNbUAbYn6ew6pEirig9npeNZ
tmAW2Csk
=hz5E
-----END PGP SIGNATURE-----

Timestamp of file with hash def105ed112e5ca86c6515d745fcbe97ae201192d92d263e45256e2841490096 -

maflcko pushed a commit that referenced this pull request Oct 16, 2019
…helpers

58d67f1 tests: Add fuzzing harness for descriptor Span-parsing helpers (practicalswift)

Pull request description:

  Add fuzzing harness for descriptor Span-parsing helpers (`spanparsing`).

  As suggested by a fuzz testing enthusiast in #16887 (comment).

  **Testing this PR**

  Run:

  ```
  $ CC=clang CXX=clang++ ./configure --enable-fuzz \
        --with-sanitizers=address,fuzzer,undefined
  $ make
  $ src/test/fuzz/spanparsing
  ```

ACKs for top commit:
  MarcoFalke:
    re-ACK 58d67f1

Tree-SHA512: 5eaca9fcda2856e0dcfeb4a98a2dc97051ae6251f7642b92fdae3ff96bb95ccb0377ee4e6c6b531e59061983b8d9485a5282467f2ab1d614861f60202a893b1c
@maflcko maflcko merged commit 58d67f1 into bitcoin:master Oct 16, 2019
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jul 9, 2020
…ng helpers

Summary:
58d67f1cc068c3779e309dc8a82ce33158c3e5b2 tests: Add fuzzing harness for descriptor Span-parsing helpers (practicalswift)

Pull request description:

  Add fuzzing harness for descriptor Span-parsing helpers (`spanparsing`).

  As suggested by a fuzz testing enthusiast in bitcoin/bitcoin#16887 (comment).

  **Testing this PR**

  Run:

  ```
  $ CC=clang CXX=clang++ ./configure --enable-fuzz \
        --with-sanitizers=address,fuzzer,undefined
  $ make
  $ src/test/fuzz/spanparsing
  ```

---

Depends on D6879

Backport of Core [[bitcoin/bitcoin#17113 | PR17113]]

Test Plan:
  cmake -GNinja .. -DENABLE_SANITIZERS="address;fuzzer" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
  ninja bitcoin-fuzzers link-fuzz-test_runner.py

run `./src/test/fuzz/spanparsing` for a few seconds

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D6880
@practicalswift practicalswift deleted the fuzzers-spanparsing branch April 10, 2021 19:38
kwvg added a commit to kwvg/dash that referenced this pull request Mar 24, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants