Remove unused styles on Windows from gitian qt build#1726
Remove unused styles on Windows from gitian qt build#1726laanwj merged 1 commit intobitcoin:masterfrom
Conversation
|
Should bump the version number too (eg, qt-win32-4.7.4-gitian.zip => qt-win32-4.7.4-gitian-r1.zip). |
|
Done |
There was a problem hiding this comment.
After -no-javascript-jit there is an unneeded space, which you could remove. And btw. now I know where the Qt static build is coming from ^^ -static. I have 2 additional switches in my local configure line, which are -no-dsp -no-vcproj. As far as I remember they are only needed for MSVC support.
Edit: And shouldn't it read -no-opengl instead of -opengl no?
Edit 2: Sorry for that many edits, but I tried the -no-feature-style-cde on Windows and I need to supply -no-style-cde for configure to work. Could be a change with Qt 4.8.2 but I wanted to mention it at least :).
|
Nice small find :). |
|
Are you sure?
Edit: now I'm sure of this: |
|
Can for sure be a difference between configure and configure.exe and if it works everything is fine :). |
|
Yep, I've verified, -no-opengl seems to be interchangable with -opengl no. |
|
Good to know :). |
Keeps the "windows", "windowsxp", "windowsvista" styles. Reduces the size of a static bitcoin-qt.exe by ~400 kB.
|
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e598b5b5c2343bcb08bcf804249bdb67180baa41 for binaries and test log. |
|
ACK. Should we pull this for 0.7rc2 ? |
|
The pull makes sense and I also used the switches in my own builds and they work (and do not harm bitcoin-qt.exe for me), so I'll vote ACK for 0.7rc2. |
|
I think it's safe to pull this for rc2. Though it means we all have to rebuild qt for the next release. |
|
missed it by THAT MUCH || |
Remove unused styles on Windows from gitian qt build
* Revert "bump to 0.12.3.0 (bitcoin#1726)" This reverts commit ccbd527. * bump to 0.12.2.2
911e31c Make CBlock::vtx a vector of shared_ptr<CTransaction> (furszy) 9d27b75 Add deserializing constructors to CTransaction and CMutableTransaction (Pieter Wuille) 5f90940 Add serialization for unique_ptr and shared_ptr (Pieter Wuille) Pull request description: Inspired on bitcoin#9125 (with many more adaptations), preparation for bitcoin#8580. Ant work 🐜 Establishing the bases for the work, we will need to continue migrating `CTransaction` to `std::shared_ptr<const CTransaction>` where is possible. Example bitcoin#8126 (can find more in bitcoin#1726 list). TODO: * back port final `CTransactionRef` implementation commit. EDIT: This is now depending on bitcoin#1816 . ACKs for top commit: random-zebra: ACK 911e31c Fuzzbawls: ACK 911e31c Tree-SHA512: 61d937aba7dce4ac0867496e7f81ae8351dcdd60b4e72c4f0ed58152a7e556bf455836c766bc97bbca331227e5deed92fa5ce609fa63bb9cb71600b430dc4405
Keeps the "windows", "windowsxp", "windowsvista" styles.
Reduces the size of a static bitcoin-qt.exe by ~400 kB.