cli: Add "headers" and "verificationprogress" to -getinfo#17302
Merged
laanwj merged 1 commit intobitcoin:masterfrom Oct 30, 2019
Merged
cli: Add "headers" and "verificationprogress" to -getinfo#17302laanwj merged 1 commit intobitcoin:masterfrom
laanwj merged 1 commit intobitcoin:masterfrom
Conversation
hebasto
reviewed
Oct 29, 2019
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
Concept ACK.
There is a typo in commit message in "verifcationprogress".
laanwj
changed the title
These value are useful to know the current progress of initial sync, or of catching up.
laanwj
force-pushed
the
2019_10_getinfo
branch
from
1a2d837 to
3187934
Compare
Member
Author
|
Thanks, fixed |
Member
|
unsigned ACK 3187934 |
Contributor
|
utACK 3187934 |
jonatack
reviewed
Oct 30, 2019
Member
There was a problem hiding this comment.
Tested ACK 3187934 on Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 GNU/Linux
$ src/bitcoin-cli -getinfo
{
"version": 199900,
"protocolversion": 70015,
"blocks": 601626,
"headers": 601626,
"verificationprogress": 0.9999914194982424,
"timeoffset": -1,
"connections": 10,
"proxy": "",
"difficulty": 13691480038694.45,
"chain": "main",
"walletversion": 169900,
"balance": 0.00649423,
"keypoololdest": 1551909091,
"keypoolsize": 1000,
"paytxfee": 0.00000000,
"relayfee": 0.00001000,
"warnings": "This is a pre-release test build - use at your own risk - do not use for mining or merchant applications"
}
Member
|
Tested 3187934 on Linux Mint 19.2: Exponential formatting of "verificationprogress" seems a bit awkward. |
Member
Author
Yes. But out of scope of this issue as I have no control over formatting as long as we're using JSON here. A progress bar would be nicer I guess. See also #17314. |
laanwj
added a commit
that referenced
this pull request
Oct 30, 2019
3187934 cli: Add "headers" and "verificationprogress" to -getinfo (Wladimir J. van der Laan) Pull request description: These values are useful to know the current progress of initial sync, or of catching up, which is arguably the use of a quick `-getinfo` command. ACKs for top commit: MarcoFalke: unsigned ACK 3187934 jonasschnelli: utACK 3187934 jonatack: Tested ACK 3187934 on Debian 4.19.37-5+deb10u2 (2019-08-08) x86_64 GNU/Linux Tree-SHA512: 185180ab426b4db5d99eb208ee88d1606f585361875ba3a92b6c28a74fe181d72ed710c8859b969ba49b1ca7d2385695932b79ff621c7a2a7cedd0df717a99ed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These values are useful to know the current progress of initial sync, or of catching up, which is arguably the use of a quick
-getinfocommand.