test: update fuzz directory in .gitignore#17452
Merged
fanquake merged 1 commit intobitcoin:masterfrom Jan 7, 2020
Merged
Conversation
maflcko
reviewed
Nov 12, 2019
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Concept ACK. The git status clutter is annoying. |
The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework. This commit: - removes `src/test/test_bitcoin_fuzzy` which is no longer used in favor of `src/test/fuzz` - ignores the src/test/fuzz directory, then un-ignores any files in it with an extension Co-authored-by: Karl-Johan Alm <[email protected]>
ba76e3c to
77ef48d
Compare
Member
Author
|
@kallewoof LMK if the GitHub email isn't your current one in order to be credited properly; I found it in the git history. |
Contributor
Looks good :) |
Member
|
@MarcoFalke or @practicalswift can either of you comment/ACK in regards to fuzzing ignoring completeness. |
Member
|
ACK 77ef48d |
Contributor
fanquake
added a commit
that referenced
this pull request
Jan 7, 2020
77ef48d gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy (Jon Atack) Pull request description: The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework. This commit: - removes `src/test/test_bitcoin_fuzzy` which is no longer used in favor of `src/test/fuzz` - ignores the `src/test/fuzz` directory, then un-ignores files in it with an extension, to de-clutter the git status from all the generated binary files. Co-authored-by: Karl-Johan Alm <[email protected]> ACKs for top commit: practicalswift: ACK 77ef48d MarcoFalke: ACK 77ef48d Tree-SHA512: 1fef4fbe88ded1ecf039205ace0da2abbaabcaae6ac6674eb29f84ae2f2fc560c1341e75e664cc2e243aca5767253756dba73b90ef32c7dd07c7c638abe6daf0
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 8, 2020
77ef48d gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy (Jon Atack) Pull request description: The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework. This commit: - removes `src/test/test_bitcoin_fuzzy` which is no longer used in favor of `src/test/fuzz` - ignores the `src/test/fuzz` directory, then un-ignores files in it with an extension, to de-clutter the git status from all the generated binary files. Co-authored-by: Karl-Johan Alm <[email protected]> ACKs for top commit: practicalswift: ACK 77ef48d MarcoFalke: ACK 77ef48d Tree-SHA512: 1fef4fbe88ded1ecf039205ace0da2abbaabcaae6ac6674eb29f84ae2f2fc560c1341e75e664cc2e243aca5767253756dba73b90ef32c7dd07c7c638abe6daf0
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
77ef48d gitignore: ignore fuzz binaries, remove test_bitcoin_fuzzy (Jon Atack) Pull request description: The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework. This commit: - removes `src/test/test_bitcoin_fuzzy` which is no longer used in favor of `src/test/fuzz` - ignores the `src/test/fuzz` directory, then un-ignores files in it with an extension, to de-clutter the git status from all the generated binary files. Co-authored-by: Karl-Johan Alm <[email protected]> ACKs for top commit: practicalswift: ACK 77ef48d MarcoFalke: ACK 77ef48d Tree-SHA512: 1fef4fbe88ded1ecf039205ace0da2abbaabcaae6ac6674eb29f84ae2f2fc560c1341e75e664cc2e243aca5767253756dba73b90ef32c7dd07c7c638abe6daf0
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Aug 6, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Aug 11, 2021
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Aug 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzzing gitignores haven't been updated since a4153e2 in 2016 that added an initial simple fuzzing framework.
This commit:
src/test/test_bitcoin_fuzzywhich is no longer used in favor ofsrc/test/fuzzsrc/test/fuzzdirectory, then un-ignores files in it with an extension, to de-clutter the git status from all the generated binary files.Co-authored-by: Karl-Johan Alm [email protected]