test: Change feature_config_args.py not to rely on strange regtest=0 behavior by ryanofsky · Pull Request #17556 · bitcoin/bitcoin

ryanofsky · 2019-11-21T22:41:52Z

Update test to simply generate a normal mainnet configuration file instead of using a crazy setup where a regtest=1 config file using an includeconf in the [regtest] section includes another config file that specifies regtest=0, retroactively switching the network to mainnet.

This setup was fragile and only worked because the triggered InitError happened early enough that none of the ignored [regtest] options mattered (only affecting log output).

This change was originally made as part of #17493

DrahtBot · 2019-11-22T00:42:12Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

laanwj · 2019-11-22T21:34:22Z

Concept ACK

instagibbs · 2019-11-26T14:34:29Z

utACK 228fb7e

test/functional/test_framework/util.py

Suggestions from MarcoFalke <[email protected]> bitcoin#17556 (review) - Fix comment mentioning chain name instead of subdirectory name - Switch from -regtest/-testnet options to -chain option

ryanofsky · 2020-02-10T20:02:52Z

Updated 228fb7e -> b339f83 (pr/wdpy.1 -> pr/wdpy.2, compare) using "" chain subdirectory instead of "main" and implementing cleanup suggestions

test/functional/test_framework/util.py

Suggestions from MarcoFalke <[email protected]> bitcoin#17556 (review) - Fix comment mentioning chain name instead of subdirectory name - Switch from -regtest/-testnet options to -chain option

ryanofsky · 2020-02-11T21:24:13Z

Rebased b339f83 -> affbdfa (pr/wdpy.2 -> pr/wdpy.3, compare) fixing silent merge conflict with #16115. Thanks Marco for looking into the test failure
Updated affbdfa -> a3c0a70 (pr/wdpy.3 -> pr/wdpy.4, compare) just editing commit message
Rebased a3c0a70 -> 8fa28f3 (pr/wdpy.4 -> pr/wdpy.5, compare) to get past cirrus freebsd failures https://cirrus-ci.com/task/6666211096264704
Updated 8fa28f3 -> f147b00 (pr/wdpy.5 -> pr/wdpy.6, compare) dropping second commit to avoid feature_backwards_compatibility.py failures https://travis-ci.org/github/bitcoin/bitcoin/jobs/723528480#L5088

Suggestions from MarcoFalke <[email protected]> bitcoin#17556 (review) - Fix comment mentioning chain name instead of subdirectory name - Switch from -regtest/-testnet options to -chain option

…behavior Update test to simply generate a normal mainnet configuration file instead of using a crazy setup where a regtest=1 config file using an includeconf in the [regtest] section includes another config file that specifies regtest=0, retroactively switching the network to mainnet. This setup was fragile and only worked because the triggered InitError happened early enough that none of the ignored [regtest] options mattered (only affecting log output).

Suggestions from MarcoFalke <[email protected]> bitcoin#17556 (review) - Fix comment mentioning chain name instead of subdirectory name - Switch from -regtest/-testnet options to -chain option

maflcko

ACK

let me know whether you want to address the nit or not

maflcko · 2020-09-06T07:54:54Z

test/functional/test_framework/util.py

+    return datadir
+
+
+def write_config(config_path, n, chain, extra_config=""):


Suggested change

def write_config(config_path, n, chain, extra_config=""):

def write_config(config_path, *, n, chain, extra_config=""):

nit: would be good to force named args to avoid mixing up n and chain. E.g. setting chain=0 will work, but is a confusing way to say mainnet.

re: #17556 (comment)

nit: would be good to force named args to avoid mixing up n and chain. E.g. setting chain=0 will work, but is a confusing way to say mainnet.

Thanks, added and updated callers.

ryanofsky

Updated f147b00 -> ff44cae (pr/wdpy.6 -> pr/wdpy.7, compare) just requiring write_config keyword arguments

ryanofsky · 2021-01-19T20:38:46Z

test/functional/test_framework/util.py

+    return datadir
+
+
+def write_config(config_path, n, chain, extra_config=""):


re: #17556 (comment)

nit: would be good to force named args to avoid mixing up n and chain. E.g. setting chain=0 will work, but is a confusing way to say mainnet.

Thanks, added and updated callers.

maflcko · 2021-01-21T15:51:52Z

ACK ff44cae

…on stra… …nge regtest=0 behavior

fanquake added the Tests label Nov 21, 2019

ryanofsky mentioned this pull request Nov 21, 2019

util: Forbid ambiguous multiple assignments in config file #17493

Draft

ryanofsky changed the title ~~Change feature_config_args.py not to rely on strange regtest=0 behavior~~ test: Change feature_config_args.py not to rely on strange regtest=0 behavior Nov 24, 2019

This was referenced Nov 24, 2019

refactor: Remove settings merge reverse precedence code #17581

Draft

Simpler settings interpretation #17508

Closed

maflcko approved these changes Feb 5, 2020

View reviewed changes

test/functional/test_framework/util.py Outdated Show resolved Hide resolved

maflcko mentioned this pull request Feb 5, 2020

test: replace 'regtest' leftovers by self.chain #18069

Merged

ryanofsky force-pushed the pr/wdpy branch from 228fb7e to b339f83 Compare February 10, 2020 19:59

maflcko reviewed Feb 10, 2020

View reviewed changes

test/functional/test_framework/util.py Outdated Show resolved Hide resolved

ryanofsky force-pushed the pr/wdpy branch from b339f83 to affbdfa Compare February 11, 2020 21:16

This was referenced Feb 11, 2020

Testschains: Many regtests with different genesis and default datadir #17037

Closed

Tests: Chainparams: Make regtest almost fully customizable #17032

Closed

DrahtBot mentioned this pull request May 12, 2020

[wip] util: Improve evaluation of includeconf lines in network sections of the config file #14866

Closed

ryanofsky force-pushed the pr/wdpy branch from affbdfa to a3c0a70 Compare August 11, 2020 23:03

ryanofsky closed this Sep 2, 2020

ryanofsky reopened this Sep 2, 2020

ryanofsky force-pushed the pr/wdpy branch from a3c0a70 to 8fa28f3 Compare September 2, 2020 17:26

ryanofsky force-pushed the pr/wdpy branch from 8fa28f3 to f147b00 Compare September 2, 2020 19:32

maflcko approved these changes Sep 6, 2020

View reviewed changes

maflcko mentioned this pull request Oct 17, 2020

qa: BitcoinTestFramework fails with extra_args=-nolisten #20177

Closed

ryanofsky force-pushed the pr/wdpy branch from f147b00 to ff44cae Compare January 19, 2021 20:41

ryanofsky commented Jan 19, 2021

View reviewed changes

maflcko merged commit 11cbd4b into bitcoin:master Jan 21, 2021

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 21, 2021

Merge bitcoin#17556: test: Change feature_config_args.py not to rely …

6d25d48

…on stra… …nge regtest=0 behavior

bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Change feature_config_args.py not to rely on strange regtest=0 behavior#17556

test: Change feature_config_args.py not to rely on strange regtest=0 behavior#17556
maflcko merged 1 commit intobitcoin:masterfrom
ryanofsky:pr/wdpy

ryanofsky commented Nov 21, 2019 •

edited

Loading

Uh oh!

DrahtBot commented Nov 22, 2019 •

edited

Loading

Uh oh!

laanwj commented Nov 22, 2019

Uh oh!

instagibbs commented Nov 26, 2019

Uh oh!

Uh oh!

ryanofsky commented Feb 10, 2020

Uh oh!

Uh oh!

ryanofsky commented Feb 11, 2020 •

edited

Loading

Uh oh!

maflcko left a comment •

edited

Loading

Uh oh!

maflcko Sep 6, 2020

Uh oh!

ryanofsky Jan 19, 2021

Uh oh!

ryanofsky left a comment

Uh oh!

ryanofsky Jan 19, 2021

Uh oh!

maflcko commented Jan 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		return datadir


		def write_config(config_path, n, chain, extra_config=""):

	def write_config(config_path, n, chain, extra_config=""):
	def write_config(config_path, *, n, chain, extra_config=""):

Conversation

ryanofsky commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Nov 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

laanwj commented Nov 22, 2019

Uh oh!

instagibbs commented Nov 26, 2019

Uh oh!

Uh oh!

ryanofsky commented Feb 10, 2020

Uh oh!

Uh oh!

ryanofsky commented Feb 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko Sep 6, 2020

Choose a reason for hiding this comment

Uh oh!

ryanofsky Jan 19, 2021

Choose a reason for hiding this comment

Uh oh!

ryanofsky left a comment

Choose a reason for hiding this comment

Uh oh!

ryanofsky Jan 19, 2021

Choose a reason for hiding this comment

Uh oh!

maflcko commented Jan 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ryanofsky commented Nov 21, 2019 •

edited

Loading

DrahtBot commented Nov 22, 2019 •

edited

Loading

ryanofsky commented Feb 11, 2020 •

edited

Loading

maflcko left a comment •

edited

Loading