ci: Add big endian platform - s390x by elichai · Pull Request #17591 · bitcoin/bitcoin

elichai · 2019-11-25T13:08:45Z

Discovered this as part of #17402 and a conversation with gmaxwell.

You can see here that the platform is indeed BE: https://travis-ci.org/elichai/bitcoin/jobs/616656410#L36

This closes #6466

laanwj · 2019-11-25T13:10:18Z

Concept ACK

Hope this works!

elichai · 2019-11-25T13:15:44Z

autotools is doing it's job good :) https://travis-ci.org/bitcoin/bitcoin/jobs/616670043#L2809

maflcko

Didn't know that s390x is be

Thanks. Concept ACK

maflcko · 2019-11-25T13:33:24Z

ci/test/00_setup_env_s390x.sh

+export GOAL="install"
+export BITCOIN_CONFIG="--enable-reduce-exports --with-incompatible-bdb"
+
+lscpu


Could add this to the script where we print free?

Now that I see that it's already printing that it's bigendian as part of the configure I don't mind removing this https://travis-ci.org/bitcoin/bitcoin/jobs/616670043#L2148

maflcko · 2019-11-25T13:36:23Z

ci/test/00_setup_env_s390x.sh

+
+export LC_ALL=C.UTF-8
+
+export HOST=s390x-unknown-linux-gnu


Suggested change

export HOST=s390x-unknown-linux-gnu

export HOST=s390x-unknown-linux-gnu

# The host arch is unknown, so we run the tests through qemu.

# If the host is arm and wants to run the tests natively, it can set QEMU_USER_CMD to the empty string.

export QEMU_USER_CMD="${QEMU_USER_CMD:"qemu-s390x"}"

And then add in the travis.yml:

QEMU_USER_CMD="" # Can run the tests natively without qemu

(just like we do for arm)

So should I also add the QEMU packages that we have in the ARM script?

Ah good catch, yes.

maflcko · 2019-11-25T13:37:22Z

ci/test/00_setup_env_s390x.sh

+export LC_ALL=C.UTF-8
+
+export HOST=s390x-unknown-linux-gnu
+export DOCKER_NAME_TAG=s390x/ubuntu:18.04


Suggested change

export DOCKER_NAME_TAG=s390x/ubuntu:18.04

Is this needed?

I'll check, in the PowerPC one Docker failed to download the right image for the platform (and instead downloaded amd64)

maflcko · 2019-11-25T13:37:40Z

ci/test/00_setup_env_s390x.sh

+export PACKAGES="clang llvm python3-zmq qtbase5-dev qttools5-dev-tools libssl1.0-dev libevent-dev bsdmainutils libboost-system-dev libboost-filesystem-dev libboost-chrono-dev libboost-test-dev libboost-thread-dev libdb5.3++-dev libminiupnpc-dev libzmq3-dev libqrencode-dev"
+export NO_DEPENDS=1
+export RUN_UNIT_TESTS=true
+export RUN_FUNCTIONAL_TESTS=false


They were timing out in PowerPC, but I didn't try them here, though because this is BE we might want to extend the timeout to make it work(because this is way more interesting then PowerPC)

maflcko · 2019-11-25T14:01:30Z

ACK da1f153

elichai · 2019-11-25T14:11:00Z

Not sure what's up with appveyor though

maflcko · 2019-11-25T14:14:00Z

Just ignore that

laanwj · 2019-11-25T14:37:19Z

yes AppVeyor issue is being fixed in #17592 and unrelated

jonatack

Concept ACK -- very nice.

DrahtBot · 2019-11-25T17:13:59Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#17402 (ci: Travis support for PowerPC64 by elichai)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

practicalswift · 2019-11-25T17:16:49Z

Concept ACK

maflcko · 2019-11-25T18:19:41Z

.travis.yml

        QEMU_USER_CMD=""  # Can run the tests natively without qemu

+    - stage: test
+      name: 'S390x  [GOAL: install]  [unit tests, functional tests]'


Suggested change

name: 'S390x [GOAL: install] [unit tests, functional tests]'

name: 'S390x [GOAL: install] [unit tests, no functional tests]'

sipa · 2019-11-25T18:57:27Z

Is there a chance of including functional tests, or is it just too slow?

da1f153 Add s390x tests to travis (Elichai Turkel) 2fa65e0 Add ci script to install on s390x (Elichai Turkel) Pull request description: Discovered this as part of #17402 and a conversation with gmaxwell. You can see here that the platform is indeed BE: https://travis-ci.org/elichai/bitcoin/jobs/616656410#L36 This closes #6466 ACKs for top commit: MarcoFalke: ACK da1f153 Tree-SHA512: e7e94e54e220257d91b24fddc79eab2bcaaadf0b2d1e7e6872d9757808ab2541728f00b1f3ab7e343305c0e7d91bb48a17a3f9621f6fff6c9fe6cde6682de408

da1f153 Add s390x tests to travis (Elichai Turkel) 2fa65e0 Add ci script to install on s390x (Elichai Turkel) Pull request description: Discovered this as part of bitcoin#17402 and a conversation with gmaxwell. You can see here that the platform is indeed BE: https://travis-ci.org/elichai/bitcoin/jobs/616656410#L36 This closes bitcoin#6466 ACKs for top commit: MarcoFalke: ACK da1f153 Tree-SHA512: e7e94e54e220257d91b24fddc79eab2bcaaadf0b2d1e7e6872d9757808ab2541728f00b1f3ab7e343305c0e7d91bb48a17a3f9621f6fff6c9fe6cde6682de408

This reverts commit 8a4438f.

6136a96 ci: Rename RUN_CI_ON_HOST to DANGER_RUN_CI_ON_HOST (Hennadii Stepanov) 97ba77a ci: Add native s390x (Hennadii Stepanov) Pull request description: Unlike the Docker wrapped solution (#17591) this PR suggests running on host system directly. This approach makes builds quick and stable (see: #18106). The excerpt from the Travis log: ``` ... Running on host system without docker wrapper ... Byte Order: Big Endian ... ``` ACKs for top commit: MarcoFalke: ACK 6136a96 Tree-SHA512: 1b591de13e38d10a35217e1de11cbd648a359d18d16eed166fac18ea5788b58cc9fc6d407086ed342b99e57e479efd951a0ea693710177e500eb116316b9a788

da1f153 Add s390x tests to travis (Elichai Turkel) 2fa65e0 Add ci script to install on s390x (Elichai Turkel) Pull request description: Discovered this as part of bitcoin#17402 and a conversation with gmaxwell. You can see here that the platform is indeed BE: https://travis-ci.org/elichai/bitcoin/jobs/616656410#L36 This closes bitcoin#6466 ACKs for top commit: MarcoFalke: ACK da1f153 Tree-SHA512: e7e94e54e220257d91b24fddc79eab2bcaaadf0b2d1e7e6872d9757808ab2541728f00b1f3ab7e343305c0e7d91bb48a17a3f9621f6fff6c9fe6cde6682de408

This reverts commit 8a4438f.

elichai added 2 commits November 25, 2019 14:34

Add ci script to install on s390x

2fa65e0

Add s390x tests to travis

da1f153

fanquake added the Tests label Nov 25, 2019

maflcko changed the title ~~Testing bitcoin in a Big Endian platform - s390x~~ ci: AddBig Endian platform - s390x Nov 25, 2019

maflcko changed the title ~~ci: AddBig Endian platform - s390x~~ ci: Add big endian platform - s390x Nov 25, 2019

maflcko approved these changes Nov 25, 2019

View reviewed changes

jonatack reviewed Nov 25, 2019

View reviewed changes

sipa mentioned this pull request Nov 25, 2019

Serialization improvements #10785

Closed

maflcko reviewed Nov 25, 2019

View reviewed changes

maflcko merged commit da1f153 into bitcoin:master Nov 25, 2019

maflcko mentioned this pull request Nov 25, 2019

ci: Run functional tests on s390x #17599

Merged

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 26, 2019

Revert "Merge bitcoin#17591: ci: Add big endian platform - s390x"

00ab4a1

This reverts commit 8a4438f.

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

hebasto mentioned this pull request Apr 8, 2020

ci: Add big endian native s390x build #18569

Merged

sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020

Revert "Merge bitcoin#17591: ci: Add big endian platform - s390x"

1b87623

This reverts commit 8a4438f.

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

-export HOST=s390x-unknown-linux-gnu
+export HOST=s390x-unknown-linux-gnu
+# The host arch is unknown, so we run the tests through qemu.
+# If the host is arm and wants to run the tests natively, it can set QEMU_USER_CMD to the empty string.
+export QEMU_USER_CMD="${QEMU_USER_CMD:"qemu-s390x"}"

	name: 'S390x [GOAL: install] [unit tests, functional tests]'
	name: 'S390x [GOAL: install] [unit tests, no functional tests]'

Conversation

elichai commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laanwj commented Nov 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elichai commented Nov 25, 2019

Uh oh!

maflcko left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maflcko commented Nov 25, 2019

Uh oh!

elichai commented Nov 25, 2019

Uh oh!

maflcko commented Nov 25, 2019

Uh oh!

laanwj commented Nov 25, 2019

Uh oh!

jonatack left a comment

Choose a reason for hiding this comment

Uh oh!

DrahtBot commented Nov 25, 2019

Conflicts

Uh oh!

practicalswift commented Nov 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sipa commented Nov 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

elichai commented Nov 25, 2019 •

edited

Loading

laanwj commented Nov 25, 2019 •

edited

Loading