Unbreak build with Boost 1.72.0 by jbeich · Pull Request #17654 · bitcoin/bitcoin

jbeich · 2019-12-02T20:01:39Z

Regressed by boostorg/filesystem@9a14c37d6f95. See error log.

Line 14 in 35eda63

#define BOOST_FILESYSTEM_NO_DEPRECATED

laanwj · 2019-12-03T15:19:27Z

ACK 90916ddf17dc39699b38ebd89e2d049b279daa08

laanwj · 2019-12-03T15:33:31Z

Note that boost 1.72 is not released yet: the site shows it in progress https://www.boost.org/users/history/in_progress.html

Can we be sure this doesn't get corrected before the release? Might make sense to wait for that.

jbeich · 2019-12-11T18:21:26Z

Boost 1.72 is released and landed in FreeBSD Ports. The fix here is still required.

maflcko · 2019-12-11T18:27:13Z

We should probably just remove BOOST_FILESYSTEM_NO_DEPRECATED again. The minimum version of boost is not going to be bumped ever again, because we will be removing boost before that happens. And until that happens, we actually want to use the deprecated features.

wallet/walletutil.cpp:77:23: error: no member named 'level' in 'boost::filesystem::recursive_directory_iterator' } else if (it.level() == 0 && it->symlink_status().type() == fs::regular_file && IsBerkeleyBtree(it... ~~ ^

jbeich · 2019-12-11T18:58:34Z

remove BOOST_FILESYSTEM_NO_DEPRECATED

Works for me.

maflcko · 2019-12-11T19:35:02Z

ACK a64e97d

a64e97d wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Regressed by boostorg/filesystem@9a14c37d6f95. See [error log](http://package22.nyi.freebsd.org/data/113amd64-default-PR241449/2019-11-27_11h48m22s/logs/bitcoin-0.19.0.1.log). https://github.com/bitcoin/bitcoin/blob/35eda631ed3bd23d4a41761a85a96f925d4a6337/src/fs.h#L14 ACKs for top commit: MarcoFalke: ACK a64e97d Tree-SHA512: 0aad2b8ec211bb81021a2f8cd2059364f949be716ebaf154dd97d5c2f7119f42553892e90e6c375018ff2155b996690c7520374762259778de88014cb531ad3b

wallet/walletutil.cpp:77:23: error: no member named 'level' in 'boost::filesystem::recursive_directory_iterator' } else if (it.level() == 0 && it->symlink_status().type() == fs::regular_file && IsBerkeleyBtree(it... ~~ ^ Github-Pull: bitcoin#17654 Rebased-From: a64e97d

fanquake · 2020-01-05T23:59:52Z

Being backported in 17858.

99b5407 scripts: fix check-symbols & check-security argument passing (fanquake) 4330a1e Update msvc build for Visual Studio 2019 v16.4 (Aaron Clauson) b0f9b8e Moves vcpkg list to a text file and updates the appveyor job and readme to use it. (Aaron Clauson) cd7b3b2 Updated appveyor config: - Update build image from Visual Studio 2017 to Visual Studio 2019. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added commands to update vcpkg port files (this does not update already installed packages). - Updated vcpkg package list as per #17309. - Removed commands setting common project file options. Now done via common.init.vcxproj include. - Changed msbuild verbosity from normal to quiet. Normal rights a LOT of logs and impacts appveyor job duration. Updated msvc project configs: - Updated platform toolset from v141 to v142. - Updated Qt static library from Qt5.9.7 to Qt5.9.8. - Added ignore for linker warning building bitcoin-qt program. - Added missing util/str.cpp class file to test_bitcoin project file. (Aaron Clauson) 112144d Add missing typeinfo includes (Wladimir J. van der Laan) 1a6a534 net: Log to net category for exceptions in ProcessMessages (Wladimir J. van der Laan) c0dc728 test: fix bitcoind already running warnings on macOS (fanquake) 5276b0e util: Add missing headers to util/fees.cpp (Hennadii Stepanov) 4d7875c rpc: require second argument only for scantxoutset start action (Andrew Chow) bda2f5b cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice (Harris) d14ab7c gui: disable File->CreateWallet during startup (fanquake) b9f1bc0 wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Backports the following PRs to the 0.19 branch: * #17654 - Unbreak build with Boost 1.72.0 * #17695 - gui: disable File->CreateWallet during startup * #17687 - cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice * #17728 - rpc: require second argument only for scantxoutset start action * #17450 - util: Add missing headers to util/fees.cpp * #17488 - test: fix "bitcoind already running" warnings on macOS * #17762 - Log to net category for exceptions in ProcessMessages * #17364 - Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes * #17416 - Appveyor improvement - text file for vcpkg package list * #17736 - Update msvc build for Visual Studio 2019 v16.4 * #17857 - scripts: fix symbol-check & security-check argument passing Fixes #17856. ACKs for top commit: sipsorcery: ACK (tested: Windows 10 & msvc build) 99b5407. Tree-SHA512: 91313de56fb0825e70a4be30ba0bf561b8c26d7dcf60549185df4f5e3524099398c828bb46faae807b631634d1afd5a1d397fb41e61ecfa0d746e4bf10b923cb

[0.19] Backports bitcoin#17858 Unbreak build with Boost 1.72.0 bitcoin#17654 cli: fix Fatal LevelDB error when specifying -blockfilterindex=basic twice bitcoin#17687 rpc: require second argument only for scantxoutset start action bitcoin#17728 wallet: Fix origfee return for bumpfee with feerate arg bitcoin#17643 test: fix "bitcoind already running" warnings on macOS bitcoin#17488 net: Log to net category for exceptions in ProcessMessages bitcoin#17762 Updates to appveyor config for VS2019 and Qt5.9.8 + msvc project fixes bitcoin#17364 Appveyor improvement - text file for vcpkg package list bitcoin#17416 Update msvc build for Visual Studio 2019 v16.4 bitcoin#17736 scripts: fix symbol-check & security-check argument passing bitcoin#17857 qt: Periodic translations update for 0.19 branch IsUsedDestination should count any known single-key address bitcoin#17621 init: Stop indexes on shutdown after ChainStateFlushed callback. bitcoin#17897 qt: Translations update pre-rc1 wallet: Reset reused transactions cache bitcoin#17843 Squashed 'src/univalue/' changes from 7890db99d6..98261b1e7b 0.19: Update univalue subtree bitcoin#18100 qt: Pre-rc2 translations update [0.19] Further 0.19 backports bitcoin#18218 build: don't embed a build-id when building libdmg-hfsplus bitcoin#18004

…stem functions Summary: Replace deprecated Boost Filesystem function (Hennadii Stepanov) Remove dead code for walletFile check (Hennadii Stepanov) Pull request description: Boost Filesystem `basename()` and `extension()` functions are [deprecated since v1.36.0](https://www.boost.org/doc/libs/1_36_0/libs/filesystem/doc/reference.html#Convenience-functions). See more: https://lists.boost.org/Archives/boost/2010/01/160905.php Also this PR prevents further use of deprecated Boost Filesystem functions. Ref: https://www.boost.org/doc/libs/1_64_0/libs/filesystem/doc/index.htm#Coding-guidelines Note: On my Linux system Boost 1.65.1 header `/usr/include/boost/filesystem/convenience.hpp` contains: ```c++ # ifndef BOOST_FILESYSTEM_NO_DEPRECATED inline std::string extension(const path & p) { return p.extension().string(); } inline std::string basename(const path & p) { return p.stem().string(); } inline path change_extension( const path & p, const path & new_extension ) { path new_p( p ); new_p.replace_extension( new_extension ); return new_p; } # endif ``` UPDATE: Also removed unused code as [noted](bitcoin/bitcoin#15880 (comment)) by **ryanofsky**. --- Backport of Core [[bitcoin/bitcoin#15880 | PR15880]] and [[bitcoin/bitcoin#17654 | PR17654]] (to unbreak PR15880) Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7362

a64e97d wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Regressed by boostorg/filesystem@9a14c37d6f95. See [error log](http://package22.nyi.freebsd.org/data/113amd64-default-PR241449/2019-11-27_11h48m22s/logs/bitcoin-0.19.0.1.log). https://github.com/bitcoin/bitcoin/blob/35eda631ed3bd23d4a41761a85a96f925d4a6337/src/fs.h#L14 ACKs for top commit: MarcoFalke: ACK a64e97d Tree-SHA512: 0aad2b8ec211bb81021a2f8cd2059364f949be716ebaf154dd97d5c2f7119f42553892e90e6c375018ff2155b996690c7520374762259778de88014cb531ad3b

Ref: bitcoin/bitcoin#17654

a64e97d wallet: unbreak with boost 1.72 (Jan Beich) Pull request description: Regressed by boostorg/filesystem@9a14c37d6f95. See [error log](http://package22.nyi.freebsd.org/data/113amd64-default-PR241449/2019-11-27_11h48m22s/logs/bitcoin-0.19.0.1.log). https://github.com/bitcoin/bitcoin/blob/35eda631ed3bd23d4a41761a85a96f925d4a6337/src/fs.h#L14 ACKs for top commit: MarcoFalke: ACK a64e97d Tree-SHA512: 0aad2b8ec211bb81021a2f8cd2059364f949be716ebaf154dd97d5c2f7119f42553892e90e6c375018ff2155b996690c7520374762259778de88014cb531ad3b

fanquake added the Wallet label Dec 2, 2019

maflcko added the Waiting for author label Dec 5, 2019

wallet: unbreak with boost 1.72

a64e97d

wallet/walletutil.cpp:77:23: error: no member named 'level' in 'boost::filesystem::recursive_directory_iterator' } else if (it.level() == 0 && it->symlink_status().type() == fs::regular_file && IsBerkeleyBtree(it... ~~ ^

maflcko removed the Waiting for author label Dec 11, 2019

maflcko added this to the 0.19.1 milestone Dec 11, 2019

maflcko added the Needs backport (0.19) label Dec 11, 2019

fanquake added Utils/log/libs and removed Wallet labels Dec 11, 2019

laanwj merged commit a64e97d into bitcoin:master Dec 13, 2019

scpeters mentioned this pull request Dec 27, 2019

boost 1.72.0 Homebrew/homebrew-core#48282

Closed

fanquake mentioned this pull request Jan 3, 2020

bitcoind fails to compile with boost 1.72.0 #17856

Closed

This was referenced Jan 3, 2020

[0.19] Backports #17858

Merged

Update .level() to .depth() #17861

Closed

fanquake removed the Needs backport (0.19) label Jan 5, 2020

fanquake mentioned this pull request Jan 15, 2020

replace deprecated method of recursive_directory_iterator with the st… #17932

Closed

ghost mentioned this pull request Jan 21, 2020

Build fails on FreeBSD 12.1 #17973

Closed

fanquake mentioned this pull request Feb 1, 2020

wallet: replace boost deprecated method call #18050

Closed

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

barton2526 added a commit to barton2526/Gridcoin-Research that referenced this pull request Jul 12, 2021

Unbreak build with Boost 1.72.0

d1536d8

Ref: bitcoin/bitcoin#17654

barton2526 mentioned this pull request Jul 12, 2021

trivial: Unbreak build with Boost 1.72.0 gridcoin-community/Gridcoin-Research#2228

Merged

barton2526 added a commit to barton2526/Gridcoin-Research that referenced this pull request Jul 13, 2021

Unbreak build with Boost 1.72.0

326d33b

Ref: bitcoin/bitcoin#17654

str4d mentioned this pull request Dec 6, 2021

Backport changes to src/fs.{cpp,h} zcash/zcash#5406

Open

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unbreak build with Boost 1.72.0#17654

Unbreak build with Boost 1.72.0#17654
laanwj merged 1 commit intobitcoin:masterfrom
jbeich:boost

jbeich commented Dec 2, 2019

Uh oh!

laanwj commented Dec 3, 2019

Uh oh!

laanwj commented Dec 3, 2019 •

edited

Loading

Uh oh!

jbeich commented Dec 11, 2019 •

edited

Loading

Uh oh!

maflcko commented Dec 11, 2019

Uh oh!

jbeich commented Dec 11, 2019

Uh oh!

maflcko commented Dec 11, 2019

Uh oh!

fanquake commented Jan 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jbeich commented Dec 2, 2019

Uh oh!

laanwj commented Dec 3, 2019

Uh oh!

laanwj commented Dec 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbeich commented Dec 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Dec 11, 2019

Uh oh!

jbeich commented Dec 11, 2019

Uh oh!

maflcko commented Dec 11, 2019

Uh oh!

fanquake commented Jan 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

laanwj commented Dec 3, 2019 •

edited

Loading

jbeich commented Dec 11, 2019 •

edited

Loading