ui: disable 3rd-party tx-urls when wallet disabled#17694
Merged
fanquake merged 1 commit intobitcoin:masterfrom Dec 9, 2019
brakmic:options-display-dialog
Merged
ui: disable 3rd-party tx-urls when wallet disabled#17694fanquake merged 1 commit intobitcoin:masterfrom brakmic:options-display-dialog
fanquake merged 1 commit intobitcoin:masterfrom
brakmic:options-display-dialog
Conversation
Contributor
|
Yes. Probably a good idea. It can always come back in node mode in case someone once adds an option to inspect the mempool or blocks, etc. Concept ACK |
Contributor
|
Could also disable with -disablewallet? |
Contributor
Author
Many thanks for the hint. It now also disables the textbox when -disablewallet. |
laanwj
reviewed
Dec 9, 2019
Member
|
Code review ACK 48a5c92 |
fanquake
added a commit
that referenced
this pull request
Dec 9, 2019
48a5c92 ui: disable 3rd-party tx-urls when wallet disabled (Harris) Pull request description: This PR closes #17683 by removing 3rd-party Url-Label and -TextBox from Display Options in wallet-disabled mode. ACKs for top commit: laanwj: Code review ACK 48a5c92 fanquake: ACK 48a5c92 - tested with and without wallet (compiled out and `-disablewallet`). Tree-SHA512: 3cc89825409fc0a3eec501c4dab5ff1caaa4ce410746a4b6ab200222fff986f4483eab90cda53a98a144be6acf1b6ca8650ab18242c39446f3335b3a9a537066
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 7, 2020
Summary: > This PR closes #17683 by removing 3rd-party Url-Label and -TextBox from Display Options in wallet-disabled mode. Issue 17683: > The part of the GUI that this setting is relevant for does not exist in a --disable-wallet build. This is a backport of Core [[bitcoin/bitcoin#17694 | PR17694]] Test Plan: `src/qt/bitcoin-qt -disablewallet` In menu `Settings -> Options -> Display`, verify that the *Third party transaction URLs` setting is not visible. Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8303
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #17683 by removing 3rd-party Url-Label and -TextBox from Display Options in wallet-disabled mode.