qt: Log Qt related info by hebasto · Pull Request #17826 · bitcoin/bitcoin

hebasto · 2019-12-29T16:38:01Z

This PR adds some info to debug.log I found useful for testing (e.g., on Wayland) and debugging issues like #17153:

$ ./src/qt/bitcoin-qt -printtoconsole | head -n 6
2020-01-04T14:57:40Z [main] Bitcoin Core version v0.19.99.0-0df287f4e (release build)
2020-01-04T14:57:40Z [main] InitParameterInteraction: parameter interaction: -externalip set -> setting -discover=0
2020-01-04T14:57:40Z [main] Qt 5.9.5 (dynamic), plugin=xcb (dynamic)
2020-01-04T14:57:40Z [main] System: Linux Mint 19.3, x86_64-little_endian-lp64
2020-01-04T14:57:40Z [main] Screen: HDMI-1 1600x1200, pixel ratio=1.0
2020-01-04T14:57:40Z [main] Assuming ancestors of block 00000000000000b7ab6ce61eb6d571003fbe5fe892da4c9b740c49a07542462d have valid signatures.

cvengler · 2019-12-29T19:12:11Z

-host is to confusing in my opinion. I think something like -debuginfo or -sysinfo would be better

DrahtBot · 2019-12-29T19:18:12Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#15768 (gui: Add close window shortcut by IPGlider)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj · 2020-01-02T20:46:31Z

Concept ACK, but yes, -host is confusing. I would expect it to do something with P2P.

-host is to confusing in my opinion. I think something like -debuginfo or -sysinfo would be better

yes, or -guiinfo or -qtinfo, to make it clear this is GUI specific

hebasto · 2020-01-03T11:53:30Z

@emilengler @laanwj
Thank you for your reviews. Your comments have been addressed.
-qtinfo is chosen as the shortest string.

The OP and the title have been updated.
Added info about Qt version and link type.

sipa · 2020-01-03T12:33:34Z

Wouldn't it be better to add this information to -version? That's where I would expect it.

EDIT: hmm, maybe not as it's not just Qt version information but also X stuff.

hebasto · 2020-01-03T12:38:17Z

@sipa

Wouldn't it be better to add this information to -version? That's where I would expect it.

-version also contains a huge piece of license info.
-qtinfo is intended to supply some environment info, that seems a bit unappropriated for -version output, no?

cvengler · 2020-01-03T19:02:59Z

@sipa

Wouldn't it be better to add this information to -version? That's where I would expect it.

I think help2man would have issues with it and it would be weird on the GNU userland if it would contain information that is not the version and license stuff.

hebasto · 2020-01-03T20:41:59Z

I think help2man would have issues with it...

help2man relies on gen-manpages.sh wrapper which in turn relies on bitcoind -version.

sipa · 2020-01-04T08:38:54Z

@hebasto You're right, the environment information does not belong in -version.

hebasto · 2020-01-04T09:51:40Z

@sipa

@hebasto You're right, the environment information does not belong in -version.

Does it mean "Concept ACK"? 😄

src/qt/bitcoin.cpp

cvengler · 2020-01-04T09:58:06Z

Concept ACK

laanwj · 2020-01-04T11:35:29Z

Wouldn't it be better to add this information to -version? That's where I would expect it.

I personally prefer -version to be a short message that just states the version. And some license info. I think it's currently fine. I wouldn't expect all kind of window system information there.

Thinking of it, this is for troubleshooting right? Let's just always log this in a message to the debug log instead of adding another step?

sipa · 2020-01-04T12:24:34Z

Concept ACK

hebasto · 2020-01-04T14:59:37Z

@laanwj

Thinking of it, this is for troubleshooting right?

Yes, it is.

Let's just always log this in a message to the debug log instead of adding another step?

Done in the latest push.

The OP has been updated.

cvengler · 2020-01-04T15:32:34Z

src/qt/guiutil.cpp

nit, do

#if defined(QT_STATIC) || defined(QT_STATICPLUGIN)

and remove the two conditions below

qt_link and plugin_link are orthogonal.

cvengler · 2020-01-04T15:32:40Z

src/qt/guiutil.cpp

promag

Code review ACK 0df287f4e4d4b8121e3879aedee925bf4b0ed1c8. I also prefer laanwj suggestion.

promag · 2020-01-04T16:34:05Z

src/qt/guiutil.cpp

qt_link and plugin_link are orthogonal.

laanwj · 2020-01-04T21:02:28Z

FWIW it doesn't seem like it detects multiple screens that form one display area.
output:

2020-01-04T20:58:32Z Qt 5.9.5 (dynamic), plugin=xcb (dynamic)
2020-01-04T20:58:32Z System: Ubuntu 18.04.3 LTS, x86_64-little_endian-lp64
2020-01-04T20:58:32Z Screen: DVI-I-1 1920x1200, pixel ratio=1.0

xrandr output:

Screen 0: minimum 320 x 200, current 3520 x 1200, maximum 16384 x 16384
DVI-I-1 connected primary 1920x1200+1600+0 (normal left inverted right x axis y axis) 519mm x 324mm
DVI-I-2 connected 1600x900+0+0 (normal left inverted right x axis y axis) 442mm x 249mm

hebasto · 2020-01-05T08:15:27Z

@laanwj

FWIW it doesn't seem like it detects multiple screens that form one display area.

Now it detects all the screens associated with the windowing system the application is connected to.
Please test.

promag

ACK 092d146da615de4722b6d171bdd2487969c374d5, now outputs all screens details.

promag · 2020-01-05T21:19:33Z

src/qt/guiutil.cpp

for (const QScreen* s : QGuiApplication::screens())?

@promag
Are these concerns relevant https://stackoverflow.com/questions/35811053/using-c11-range-based-for-loop-correctly-in-qt ?

It's fine here, these are pointers.

Implemented in the latest push.

laanwj · 2020-01-08T13:22:03Z

Thanks, works now!

2020-01-08T13:20:54Z Qt 5.9.5 (dynamic), plugin=xcb (dynamic)
2020-01-08T13:20:54Z System: Ubuntu 18.04.3 LTS, x86_64-little_endian-lp64
2020-01-08T13:20:54Z Screen: DVI-I-1 1920x1200, pixel ratio=1.0
2020-01-08T13:20:54Z Screen: DVI-I-2 1600x900, pixel ratio=1.0

ACK a004673

a004673 qt: Add LogQtInfo() function (Hennadii Stepanov) Pull request description: This PR adds some info to `debug.log` I found useful for testing (e.g., on Wayland) and debugging issues like #17153: ``` $ ./src/qt/bitcoin-qt -printtoconsole | head -n 6 2020-01-04T14:57:40Z [main] Bitcoin Core version v0.19.99.0-0df287f4e (release build) 2020-01-04T14:57:40Z [main] InitParameterInteraction: parameter interaction: -externalip set -> setting -discover=0 2020-01-04T14:57:40Z [main] Qt 5.9.5 (dynamic), plugin=xcb (dynamic) 2020-01-04T14:57:40Z [main] System: Linux Mint 19.3, x86_64-little_endian-lp64 2020-01-04T14:57:40Z [main] Screen: HDMI-1 1600x1200, pixel ratio=1.0 2020-01-04T14:57:40Z [main] Assuming ancestors of block 00000000000000b7ab6ce61eb6d571003fbe5fe892da4c9b740c49a07542462d have valid signatures. ``` ACKs for top commit: laanwj: ACK a004673 Tree-SHA512: 496bcfd4870a2730eab92b96b3e74989a7904b21369c372b6d4368f4ca2c141e2fdc1348a1fdd18cb68bb144dcea01d3023bb782f9d030e330c187f6a5a1a082

Summary: Add information to debug log about Qt, the OS, the screens. This is a backport of Core [[bitcoin/bitcoin#17826 | PR17826]] Test Plan: ``` $ ninja && src/qt/bitcoin-qt -regtest -printtoconsole | head -n6 [219/219] Linking CXX executable src/qt/bitcoin-qt 2020-11-13T15:28:52Z Bitcoin ABC version v0.22.7-3ba582bc3 (release build) 2020-11-13T15:28:52Z Qt 5.12.8 (dynamic), plugin=xcb (dynamic) 2020-11-13T15:28:52Z System: Ubuntu 20.04.1 LTS, x86_64-little_endian-lp64 2020-11-13T15:28:52Z Screen: DVI-I-1 1920x1080, pixel ratio=1.0 2020-11-13T15:28:52Z Screen: DVI-D-1 1920x1080, pixel ratio=1.0 2020-11-13T15:28:53Z Checkpoints will be verified. ``` Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8393

957895c util: Log static plugins meta data and style (Hennadii Stepanov) Pull request description: This PR is a follow-up of bitcoin/bitcoin#17826, and adds additional info about the imported static plugins and the used style to the `debug.log` I found useful for testing (e.g., with `QT_QPA_PLATFORM`, `QT_QPA_PLATFORMTHEME`, `QT_STYLE_OVERRIDE` variables) and debugging issues (e.g., bitcoin/bitcoin#19716 (comment)). The excerpt from the log: ``` 2020-11-15T18:41:45Z [main] Bitcoin Core version v0.20.99.0-f0b933f78 (release build) 2020-11-15T18:41:45Z [main] Qt 5.9.8 (static), plugin=xcb (static) 2020-11-15T18:41:45Z [main] Static plugins: 2020-11-15T18:41:45Z [main] QXcbIntegrationPlugin, version 329992 2020-11-15T18:41:45Z [main] Style: fusion / QFusionStyle ... ``` ACKs for top commit: jarolrod: ACK 957895c, Tested on macOS 11.1 jonasschnelli: utACK 957895c Tree-SHA512: 0e46db7560f380fbda8ce5e53faa5d419a456e90ca595ce46be8e3030c99d3a113586edad1988a97e9bf0279e944f975968ed1156817bc16723ed31c64850239

…d style 957895c util: Log static plugins meta data and style (Hennadii Stepanov) Pull request description: This PR is a follow-up of bitcoin#17826, and adds additional info about the imported static plugins and the used style to the `debug.log` I found useful for testing (e.g., with `QT_QPA_PLATFORM`, `QT_QPA_PLATFORMTHEME`, `QT_STYLE_OVERRIDE` variables) and debugging issues (e.g., bitcoin#19716 (comment)). The excerpt from the log: ``` 2020-11-15T18:41:45Z [main] Bitcoin Core version v0.20.99.0-f0b933f78 (release build) 2020-11-15T18:41:45Z [main] Qt 5.9.8 (static), plugin=xcb (static) 2020-11-15T18:41:45Z [main] Static plugins: 2020-11-15T18:41:45Z [main] QXcbIntegrationPlugin, version 329992 2020-11-15T18:41:45Z [main] Style: fusion / QFusionStyle ... ``` ACKs for top commit: jarolrod: ACK 957895c, Tested on macOS 11.1 jonasschnelli: utACK 957895c Tree-SHA512: 0e46db7560f380fbda8ce5e53faa5d419a456e90ca595ce46be8e3030c99d3a113586edad1988a97e9bf0279e944f975968ed1156817bc16723ed31c64850239

fanquake added the GUI label Dec 29, 2019

hebasto force-pushed the 20191229-host-info branch from 6981076 to 5ea7c91 Compare January 3, 2020 11:46

hebasto changed the title ~~qt: Add -host command-line option~~ qt: Add -qtinfo command-line option Jan 3, 2020

cvengler reviewed Jan 4, 2020

View reviewed changes

src/qt/bitcoin.cpp Outdated Show resolved Hide resolved

hebasto force-pushed the 20191229-host-info branch from 5ea7c91 to 0df287f Compare January 4, 2020 14:58

hebasto changed the title ~~qt: Add -qtinfo command-line option~~ qt: Log Qt related info Jan 4, 2020

cvengler reviewed Jan 4, 2020

View reviewed changes

src/qt/guiutil.cpp Outdated

Copy link

Contributor

cvengler Jan 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

promag reviewed Jan 4, 2020

View reviewed changes

src/qt/guiutil.cpp Outdated

Copy link

Contributor

promag Jan 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qt_link and plugin_link are orthogonal.

hebasto force-pushed the 20191229-host-info branch from 0df287f to 092d146 Compare January 5, 2020 08:12

promag reviewed Jan 5, 2020

View reviewed changes

qt: Add LogQtInfo() function

a004673

hebasto force-pushed the 20191229-host-info branch from 092d146 to a004673 Compare January 5, 2020 21:41

laanwj merged commit a004673 into bitcoin:master Jan 8, 2020

hebasto deleted the 20191229-host-info branch January 8, 2020 14:46

MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Jan 12, 2020

[gui] Log Qt related info (bitcoin#17826)

fa0215b

hebasto mentioned this pull request Feb 19, 2020

bitcoind throw error Cannot create connection if there are more than 1024 cocurrent connections #18158

Closed

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

hebasto mentioned this pull request Aug 24, 2020

util: Log static plugins meta data and used style bitcoin-core/gui#72

Merged

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

Conversation

hebasto commented Dec 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvengler commented Dec 29, 2019

Uh oh!

DrahtBot commented Dec 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

laanwj commented Jan 2, 2020

Uh oh!

hebasto commented Jan 3, 2020

Uh oh!

sipa commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Jan 3, 2020

Uh oh!

cvengler commented Jan 3, 2020

Uh oh!

hebasto commented Jan 3, 2020

Uh oh!

sipa commented Jan 4, 2020

Uh oh!

hebasto commented Jan 4, 2020

Uh oh!

Uh oh!

cvengler commented Jan 4, 2020

Uh oh!

laanwj commented Jan 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sipa commented Jan 4, 2020

Uh oh!

hebasto commented Jan 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

promag left a comment • edited by laanwj Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj commented Jan 4, 2020

Uh oh!

hebasto commented Jan 5, 2020

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

laanwj commented Jan 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hebasto commented Dec 29, 2019 •

edited

Loading

DrahtBot commented Dec 29, 2019 •

edited

Loading

sipa commented Jan 3, 2020 •

edited

Loading

laanwj commented Jan 4, 2020 •

edited

Loading

hebasto commented Jan 4, 2020 •

edited

Loading

promag left a comment •

edited by laanwj

Loading