refactor: Remove unused defines in qt/bitcoinunits.h#17869
Merged
fanquake merged 1 commit intobitcoin:masterfrom Jan 5, 2020
Merged
refactor: Remove unused defines in qt/bitcoinunits.h#17869fanquake merged 1 commit intobitcoin:masterfrom
fanquake merged 1 commit intobitcoin:masterfrom
Conversation
maflcko
changed the title
Member
|
I looked at the history of |
Member
Author
These |
Contributor
|
Just grepped all removed defines. ACK 7754d7a |
Contributor
|
ACK 7754d7a. |
fanquake
approved these changes
Jan 5, 2020
fanquake
added a commit
that referenced
this pull request
Jan 5, 2020
7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov) Pull request description: In `bitcoinunits.h` some `#define`s introduced in #4167 are unused now. ACKs for top commit: emilengler: ACK 7754d7a fanquake: ACK 7754d7a promag: ACK 7754d7a. Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 5, 2020
…ts.h 7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov) Pull request description: In `bitcoinunits.h` some `#define`s introduced in bitcoin#4167 are unused now. ACKs for top commit: emilengler: ACK 7754d7a fanquake: ACK 7754d7a promag: ACK 7754d7a. Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 6, 2020
- gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged bitcoin#18160 - gui: Drop PeerTableModel dependency to ClientModel bitcoin#18060 - gui: Break trivial circular dependencies bitcoin#18036 - gui: Improve "Hide" button tool-tip message bitcoin#17360 - gui: Shortcut to close ModalOverlay bitcoin#17998 - gui: Remove warning "unused variable 'wallet_model'" bitcoin#17939 - refactor: Use PACKAGE_NAME in GUI modal overlay and bitcoin-wallet bitcoin#17923 - gui: remove OpenSSL PRNG seeding (Windows, Qt only) bitcoin#17151 - refactor: Remove unused defines in qt/bitcoinunits.h bitcoin#17869
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 28, 2020
Summary: This code was added in [[bitcoin/bitcoin@7007402 | 7007402]] and unused in the very next commit [[bitcoin/bitcoin@2e4fee2 | 2e4fee2]] Backport of Core [[bitcoin/bitcoin#17869 | PR17869]] Test Plan: ``` for IDENTIFIER in REAL_THIN_SP_HTML HAIR_SP_CP HAIR_SP_UTF8 HAIR_SP_HTML SIXPEREM_SP_CP SIXPEREM_SP_UTF8 SIXPEREM_SP_HTML FIGURE_SP_CP FIGURE_SP_UTF8 FIGURE_SP_HTML; do grep -r $IDENTIFIER src/; done ``` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7577
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
…ts.h 7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov) Pull request description: In `bitcoinunits.h` some `#define`s introduced in bitcoin#4167 are unused now. ACKs for top commit: emilengler: ACK 7754d7a fanquake: ACK 7754d7a promag: ACK 7754d7a. Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…ts.h 7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov) Pull request description: In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now. ACKs for top commit: emilengler: ACK 7754d7a fanquake: ACK 7754d7a promag: ACK 7754d7a. Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 15, 2021
…ts.h 7754d7a refactor: Remove unused defines in bitcoinunits.h (Hennadii Stepanov) Pull request description: In `bitcoinunits.h` some `#define`s introduced in dashpay#4167 are unused now. ACKs for top commit: emilengler: ACK 7754d7a fanquake: ACK 7754d7a promag: ACK 7754d7a. Tree-SHA512: 688836a434d87530f99c309d8af60f63cdfdcfe583c9297636fbbed0f16a3dc0920d4249457303c00a83dc82d28edd8a99aab0b191c7ffbbd38c5d9fc8ee0df1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
bitcoinunits.hsome#defines introduced in #4167 are unused now.