gui: uncheck encrypt by default when creating wallet#17879
Closed
Sjors wants to merge 1 commit intobitcoin:masterfrom
Closed
gui: uncheck encrypt by default when creating wallet#17879Sjors wants to merge 1 commit intobitcoin:masterfrom
Sjors wants to merge 1 commit intobitcoin:masterfrom
Conversation
Sjors
force-pushed
the
2020/01/ui-create-wallet
branch
from
991389d to
4523d0f
Compare
Member
|
Concept NACK. I think we should create encrypted wallets by default. It's harder to do that on the command line that it is in the GUI since it requires user interaction. |
Member
|
concept NACK in general. Maybe we should allow "Disable private keys" to be clicked, which unclicks the "Encrypt wallet" checkbox? |
Member
Author
That seems like a reasonable UX compromise. |
Member
|
tbh, this whole dialog looks very user-unfriendly. What does "Make Blank Wallet" even mean to an end user?? ("Disable Private Keys" is probably borderline confusing itself) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for bike-shedding, but I find this default confusing:
We don't encrypt the default wallet by default, so I don't think we should do it with new wallets. When creating a watch-only wallet - which I suspect is a more common use case than a second regular wallet - you have to uncheck the box first before you can check the watch-only box.
This PR unchecks the encryption box by default:
