wallet: Give slightly more understandable advice when needing -fallbackfee#18214
Closed
instagibbs wants to merge 1 commit intobitcoin:masterfrom
Closed
wallet: Give slightly more understandable advice when needing -fallbackfee#18214instagibbs wants to merge 1 commit intobitcoin:masterfrom
instagibbs wants to merge 1 commit intobitcoin:masterfrom
Conversation
maflcko
changed the title
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Feb 28, 2020
maflcko
reviewed
Feb 28, 2020
| if (feeCalc.reason == FeeReason::FALLBACK && !m_allow_fallback_fee) { | ||
| // eventually allow a fallback fee | ||
| strFailReason = _("Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee.").translated; | ||
| strFailReason = _("Fee estimation failed. Fallbackfee is disabled. Wait a few blocks or enable -fallbackfee=<BTC/kB>.").translated; |
Member
There was a problem hiding this comment.
Tend to NACK
- The documentation (
-helpor-?) is already pretty clear on this being an amount and not a flag - This is a translation string, so all translations are invalided, for little reason. Also, it complicates translations
- The underlying bug should be fixed. See util: Fail to parse empty string in ParseMoney #18225
Member
Author
There was a problem hiding this comment.
FWIW debug logs already do it:
src/qt/bitcoinstrings.cpp:137:QT_TRANSLATE_NOOP("bitcoin-core", "Invalid amount for -fallbackfee=<amount>: '%s'"),
src/wallet/wallet.cpp:3799: error = strprintf(_("Invalid amount for -fallbackfee=<amount>: '%s'").translated, gArgs.GetArg("-fallbackfee", ""));
fanquake
added a commit
that referenced
this pull request
Feb 29, 2020
8888461 util: Fail to parse empty string in ParseMoney (MarcoFalke) fab30b6 util: Remove unused ParseMoney that takes a c_str (MarcoFalke) Pull request description: Supplying a fee rate or an amount on the command line as an empty string, which currently parses as `0` seems fragile and confusing. See for example the confusion in #18214. Fixes #18214 ACKs for top commit: Empact: Code Review ACK 8888461 achow101: ACK 8888461 instagibbs: utACK 8888461 Tree-SHA512: ac2d6b7fa89fe5809c34d5f49831042032591c34fb3c76908d72fed51e8bced41bf2b41dc1b3be34ee691a40463355649857a7a8f378709d38ae89503feb11c2
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 29, 2020
8888461 util: Fail to parse empty string in ParseMoney (MarcoFalke) fab30b6 util: Remove unused ParseMoney that takes a c_str (MarcoFalke) Pull request description: Supplying a fee rate or an amount on the command line as an empty string, which currently parses as `0` seems fragile and confusing. See for example the confusion in bitcoin#18214. Fixes bitcoin#18214 ACKs for top commit: Empact: Code Review ACK bitcoin@8888461 achow101: ACK 8888461 instagibbs: utACK bitcoin@8888461 Tree-SHA512: ac2d6b7fa89fe5809c34d5f49831042032591c34fb3c76908d72fed51e8bced41bf2b41dc1b3be34ee691a40463355649857a7a8f378709d38ae89503feb11c2
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
8888461 util: Fail to parse empty string in ParseMoney (MarcoFalke) fab30b6 util: Remove unused ParseMoney that takes a c_str (MarcoFalke) Pull request description: Supplying a fee rate or an amount on the command line as an empty string, which currently parses as `0` seems fragile and confusing. See for example the confusion in bitcoin#18214. Fixes bitcoin#18214 ACKs for top commit: Empact: Code Review ACK bitcoin@8888461 achow101: ACK 8888461 instagibbs: utACK bitcoin@8888461 Tree-SHA512: ac2d6b7fa89fe5809c34d5f49831042032591c34fb3c76908d72fed51e8bced41bf2b41dc1b3be34ee691a40463355649857a7a8f378709d38ae89503feb11c2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current advice leads users like myself to add
-fallbackfeealone which appears to do nothing.