rpc: change setmocktime check to use IsMockableChain #18263
Merged
maflcko merged 1 commit intobitcoin:masterfrom Mar 5, 2020
Merged
rpc: change setmocktime check to use IsMockableChain #18263maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
glozow
changed the title
glozow
changed the title
glozow
changed the title
glozow
changed the title
Contributor
|
ACK 4264e97b42e87ff1e103eb1f919cff4c0f56c4fe. Thanks for this follow up :) |
jonatack
reviewed
Mar 5, 2020
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK 4264e97b42e87ff1e103eb1f919cff4c0f56c4fe modulo nits
Contributor
|
ACK 4264e97b42e87ff1e103eb1f919cff4c0f56c4fe. |
Member
|
Please squash your commits according to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
glozow
force-pushed
the
rpc-setmocktime-check
branch
from
e8600d9 to
2455aa5
Compare
Member
|
ACK 2455aa5 🙇 Show signature and timestampSignature: Timestamp of file with hash |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 5, 2021
Summary: > Change: Update the if statement in setmocktime to use IsMockableChain chainparams function (aka m_is_mockable_chain) instead of MineBlocksOnDemand > > Rationale: It's a more appropriate check for whether or not chain is in RegTest, as discussed in [[bitcoin/bitcoin#18037 | PR18037]] This is a backport of Core [[bitcoin/bitcoin#18263 | PR18263]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8783
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change: Update the if statement in
setmocktimeto useIsMockableChainchainparams function (akam_is_mockable_chain) instead ofMineBlocksOnDemandRationale: It's a more appropriate check for whether or not chain is in RegTest, as discussed in #18037