scheduler: Workaround negative nsecs bug in boost's wait_until#18271
Closed
luke-jr wants to merge 1 commit intobitcoin:masterfrom
Closed
scheduler: Workaround negative nsecs bug in boost's wait_until#18271luke-jr wants to merge 1 commit intobitcoin:masterfrom
luke-jr wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
This was referenced Mar 6, 2020
Contributor
|
I think travis is failing because this catches |
Some boost versions have a bug that can cause a time prior to system boot (or wake from sleep) to throw an exception instead of return timeout See boostorg/thread#308
luke-jr
force-pushed
the
wrkarnd_boost_wait_until
branch
from
1255050 to
ed0223e
Compare
Member
Author
|
That could break in a race (suspend after check, but before wait_until). Fixed it by always rethrowing |
Member
|
Please enable the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some boost versions have a bug that can cause a time prior to system boot (or wake from sleep) to throw an exception instead of return timeout
See boostorg/thread#308
Fixes #18227
Cleanly merges to 0.14+