Skip to content

doc: asmap release note#18310

Merged
maflcko merged 1 commit intobitcoin:masterfrom
jonatack:asmap-release-note
Mar 11, 2020
Merged

doc: asmap release note#18310
maflcko merged 1 commit intobitcoin:masterfrom
jonatack:asmap-release-note

Conversation

@jonatack
Copy link
Member

Unsure how much detail to provide. Feedback welcome.

@jonatack
Copy link
Member Author

@flack
Copy link
Contributor

flack commented Mar 10, 2020

fyi, you can also see the markdown rendering in the PR if you click the "rich diff" button:

richdiff

https://github.com/bitcoin/bitcoin/pull/18310/files?short_path=ef76fd6#diff-ef76fd6674f07db88c3422fdbf0bcf9f

@DrahtBot DrahtBot added the Docs label Mar 10, 2020
@laanwj
Copy link
Member

laanwj commented Mar 11, 2020

fyi, you can also see the markdown rendering in the PR if you click the "rich diff" button:

TIL!

@laanwj
Copy link
Member

laanwj commented Mar 11, 2020

ACK ac73afb

Unsure how much detail to provide.

I think this is exactly the right level of detail for a release notes entry.

@maflcko
Copy link
Member

maflcko commented Mar 11, 2020

cc @naumenkogs

@naumenkogs
Copy link
Contributor

ACK ac73afb

@maflcko maflcko merged commit 9c507a7 into bitcoin:master Mar 11, 2020
@jonatack jonatack deleted the asmap-release-note branch March 11, 2020 14:14
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 11, 2020
ac73afb doc: asmap release note (Jon Atack)

Pull request description:

  Unsure how much detail to provide. Feedback welcome.

ACKs for top commit:
  laanwj:
    ACK ac73afb
  naumenkogs:
    ACK ac73afb

Tree-SHA512: 6fd26f83084db913f2683ced799a4d50a26cd81cdf282bd0ae5364d2ab48b7508b358fd88e0aca5b31bbabb8a0015ca4aca49d690c136776d33b83ca95603393
jasonbcox pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 1, 2020
Summary:
Should have gone with the [[bitcoin/bitcoin#16702 | PR16702]] backport (D8194 to D8197).

Backport of core [[bitcoin/bitcoin#18310 | PR18310]].

Test Plan: Read it.

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D8217
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
ac73afb doc: asmap release note (Jon Atack)

Pull request description:

  Unsure how much detail to provide. Feedback welcome.

ACKs for top commit:
  laanwj:
    ACK ac73afb
  naumenkogs:
    ACK ac73afb

Tree-SHA512: 6fd26f83084db913f2683ced799a4d50a26cd81cdf282bd0ae5364d2ab48b7508b358fd88e0aca5b31bbabb8a0015ca4aca49d690c136776d33b83ca95603393
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants