Build: Move wallet RPCs to their own libbitcoin_walletrpcs module#18469
Closed
luke-jr wants to merge 3 commits intobitcoin:masterfrom
Closed
Build: Move wallet RPCs to their own libbitcoin_walletrpcs module#18469luke-jr wants to merge 3 commits intobitcoin:masterfrom
luke-jr wants to merge 3 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Mar 30, 2020
Contributor
|
I will be honest and say I don't really understand how this PR is trying to organize the libraries and API, but I did post an alternate fix #18465 (comment) that I think addresses the problem simply and directly |
This was referenced Mar 30, 2020
Member
Author
|
@ryanofsky The point here is to only link wallet RPC stuff when there is a RPC server (and therefore |
This was referenced Mar 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to fix #18465. This also trims the RPC code out of the
bitcoin-walletbuild.The build currently fails for
bench_bitcoinfor reasons I can't figure out.Also, I'm not really sure what is needed for MSVC.
Chasing Concept ACKs for now (or ideas for alternative directions, please post to #18465 )