RPC: Show fee in results for signrawtransaction* for segwit inputs#18479
Closed
luke-jr wants to merge 5 commits intobitcoin:masterfrom
Closed
RPC: Show fee in results for signrawtransaction* for segwit inputs#18479luke-jr wants to merge 5 commits intobitcoin:masterfrom
luke-jr wants to merge 5 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Concept ACK. |
This was referenced Mar 31, 2020
a2dab3e to
5a34f93
Compare
This was referenced Apr 23, 2020
5a34f93 to
d47aefb
Compare
d47aefb to
a1da1f9
Compare
Member
Author
|
Rebased again |
maflcko
reviewed
Aug 23, 2020
The fee is considered known when all inputs are segwit inputs (which means amounts are enforced/known)..
a1da1f9 to
ddb8d02
Compare
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
fanquake
reviewed
Mar 15, 2021
|
|
||
| // Script verification errors | ||
| std::map<int, std::string> input_errors; | ||
| Optional<CAmount> inputs_amount_sum; |
Member
Author
|
Closing due to lack of interest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #12911