tests: add CScriptNum::serialize to integer fuzz harness#18491
Closed
pierreN wants to merge 1 commit intobitcoin:masterfrom
Closed
tests: add CScriptNum::serialize to integer fuzz harness#18491pierreN wants to merge 1 commit intobitcoin:masterfrom
pierreN wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
@pierreN Thanks for contributing to the fuzzers.
That leaves Instead of adding a new fuzzing file just for |
pierreN
changed the title
Contributor
Author
|
Ow, my bad. Thanks, I updated the PR accordingly. |
Contributor
|
ACK 7a21407 |
Contributor
Author
|
Thanks. Note that tests fail since #18413 is not merged AFAIK. |
Member
Could add the tests to that pull and close this one? |
Contributor
Author
|
Yes good idea, I just added the test to the original PR : c6819c4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a fuzzing harness for
CScriptNum::serialize,core_write.cpp:ValueFromAmountandutil/moneystr.cpp:FormatMoney.Those functions manually compute absolute values of
int64_tnumbers which can lead to undefined behavior, see : #18413 #18046You can trigger this new harness with the following input :
Note that
BitcoinUnits::formatalso does the same (but requires QT headers to compile so I'm not sure we can add it to the fuzzer).