doc: Update docs for getbalance (default minconf should be 0)#18502
doc: Update docs for getbalance (default minconf should be 0)#18502maflcko merged 1 commit intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
ACK, LGTM.
I think it would make sense to squash the two commits into one.
Sure. I felt they are 2 separate ideas, thus they are separate. Got your point though. Should I close this issue and resubmit with the squashed commits? |
There's no need to open a new PR just to squash commits, you can do that in this PR. |
Summary: > - Default minconf for getbalance is 0 but example in doc was showing as 1. > - at least 6 blocks confirmed now updated to be at least 6 confirmations to be more consistent with the terminology used elsewhere in the codebase and documentations. This is a backport of Core [[bitcoin/bitcoin#18502 | PR18502]] Test Plan: Check the new help message: `src/bitcoin-cli help getbalance` Check that the balance includes unconfirmed transactions by sending some fund to an external wallet and running immediately `src/bitcoin-cli getbalance` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8924
…ault minconf should be 0)
… should be 0) (#4372) * Merge bitcoin#18502: doc: Update docs for getbalance (default minconf should be 0) * Backporting Merge bitcoin#18502: doc: Update docs for getbalance (default minconf should be 0) * Update src/wallet/rpcwallet.cpp Co-authored-by: UdjinM6 <[email protected]>
6 participants
minconfforgetbalanceis0but example in doc was showing as1.at least 6 blocks confirmednow updated to beat least 6 confirmationsto be more consistent with the terminology used elsewhere in the codebase and documentations.