Add test for -blocksonly and -whitelistforcerelay param interaction#18530
Merged
maflcko merged 2 commits intobitcoin:masterfrom May 21, 2020
Merged
Add test for -blocksonly and -whitelistforcerelay param interaction#18530maflcko merged 2 commits intobitcoin:masterfrom
maflcko merged 2 commits intobitcoin:masterfrom
Conversation
glowang
commented
Apr 5, 2020
glowang
commented
Apr 5, 2020
glowang
commented
Apr 5, 2020
glowang
commented
Apr 5, 2020
glowang
changed the title
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
maflcko
reviewed
Apr 5, 2020
Member
|
Concept ACK |
maflcko
reviewed
Apr 8, 2020
maflcko
reviewed
Apr 8, 2020
glowang
force-pushed
the
add_blocksonly_tests
branch
from
037f2d3 to
bc432ee
Compare
maflcko
reviewed
Apr 12, 2020
glowang
commented
Apr 12, 2020
glowang
force-pushed
the
add_blocksonly_tests
branch
2 times, most recently
from
c273658 to
63924b8
Compare
glowang
changed the title
glowang
force-pushed
the
add_blocksonly_tests
branch
from
63924b8 to
209da1b
Compare
glowang
changed the title
glowang
force-pushed
the
add_blocksonly_tests
branch
2 times, most recently
from
ef96f10 to
f348b9b
Compare
glowang
commented
Apr 18, 2020
glowang
commented
Apr 18, 2020
maflcko
reviewed
Apr 18, 2020
Member
|
From travis: |
glowang
force-pushed
the
add_blocksonly_tests
branch
2 times, most recently
from
0a828f4 to
13cff3a
Compare
glowang
commented
Apr 25, 2020
glowang
force-pushed
the
add_blocksonly_tests
branch
from
13cff3a to
18e5f49
Compare
maflcko
reviewed
Apr 28, 2020
glowang
force-pushed
the
add_blocksonly_tests
branch
from
18e5f49 to
c51c8a2
Compare
glowang
force-pushed
the
add_blocksonly_tests
branch
from
c51c8a2 to
be01449
Compare
Contributor
Author
|
All comments have been addressed. This PR is ready for review. |
maflcko
approved these changes
May 10, 2020
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
Concept ACK. Thanks for working on the documentation and adding tests.
maflcko
reviewed
May 15, 2020
glowang
force-pushed
the
add_blocksonly_tests
branch
from
248d2b8 to
0ea5d70
Compare
Contributor
Author
|
net_processing.cpp file comment has been updated. ready for re-review. |
Member
|
ACK 0ea5d70 |
Member
|
Thanks again for improving documentation and adding tests. This should be ready for merge now. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 21, 2020
…y param interaction 0ea5d70 Updated comment for the condition where a transaction relay is denied (glowang) be01449 Add test for param interaction b/w -blocksonly and -whitelistforcerelay (glowang) Pull request description: Related to: bitcoin#18428 When -blocksonly is turned on, a node would still relay transactions from whitelisted peers. This funcitonality has not been tested. ACKs for top commit: MarcoFalke: ACK 0ea5d70 Tree-SHA512: 4e99c88281cb518cc67f5f3be7171a7b413933047b5d24a04bb3ff2210a82e914d69079f64cd5bac9206ec435e21a622c8e69cedbc2ccb39d2328ac5c01668e5
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 8, 2021
Summary: Updated comment for the condition where a transaction relay is denied This is a backport of Core [[bitcoin/bitcoin#18530 | PR18530]] Test Plan: test/functional/test_runner.py p2p_blocksonly Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D9145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #18428
When -blocksonly is turned on, a node would still relay transactions from whitelisted peers. This funcitonality has not been tested.