ci: Add big endian native s390x build#18569
Conversation
hebasto
changed the title
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
I don't really like going back to using the travis environment, which is in constant flux and thus more brittle. Also, as they replace vanilla packages with their own versions (pyenv etc), debugging failures locally is probably going to be a pain.
But if this runs without much hassle, why not.
.travis.yml
Outdated
| cache: | ||
| directories: | ||
| - $TRAVIS_BUILD_DIR/ci/scratch/.ccache | ||
| - $TRAVIS_BUILD_DIR/releases/$HOST |
There was a problem hiding this comment.
To get rid of smth like this:
adding /usr/local/Homebrew to cache
creating directory /usr/local/Homebrew
mkdir: cannot create directory ‘/usr/local/Homebrew’: Permission denied
/usr/local/Homebrew is not yet cached
/usr/local/Homebrew: No such file or directory
/usr/local/Homebrew: unknown file type
There was a problem hiding this comment.
In that case, I'd rather move the overwrite to macos, since that is causing the trouble
ci/test/00_setup_env_s390x_host.sh
Outdated
| export LC_ALL=C.UTF-8 | ||
|
|
||
| export HOST=s390x-linux-gnu | ||
| export RUN_CI_ON_HOST=true |
There was a problem hiding this comment.
This is a dangerous setting. Would be best to put this in the .travis.yml to make sure no one is setting this locally and trashing their machine?
Edit: The setting should probably be renamed to DANGER_RUN_CI_ON_HOST or so
There was a problem hiding this comment.
The setting should probably be renamed to DANGER_RUN_CI_ON_HOST or so
Implemented.
hebasto
force-pushed
the
20200326-allow-s390x
branch
2 times, most recently
from
42b45d0 to
8d4ff5c
Compare
.travis.yml
Outdated
| - $TRAVIS_BUILD_DIR/ci/scratch/.ccache | ||
| - $TRAVIS_BUILD_DIR/releases/$HOST | ||
| - $HOME/Library/Caches/Homebrew | ||
| - /usr/local/Homebrew |
There was a problem hiding this comment.
Isn't this build cross compilation? I think this whole hunk can be discarded.
hebasto
force-pushed
the
20200326-allow-s390x
branch
from
8d4ff5c to
6136a96
Compare
hebasto
changed the title
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
ACK 6136a96 |
4 participants
Unlike the Docker wrapped solution (#17591) this PR suggests running on host system directly.
This approach makes builds quick and stable (see: #18106).
The excerpt from the Travis log: