fuzz: Disable debug log file#18571
Merged
maflcko merged 3 commits intobitcoin:masterfrom Apr 15, 2020
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 9, 2020
maflcko
force-pushed
the
2004-testLogExtraArgs
branch
from
fae06f8 to
facc7e5
Compare
maflcko
force-pushed
the
2004-testLogExtraArgs
branch
from
ead5571 to
f5d6a22
Compare
Contributor
|
Concept ACK Thanks for doing this: faster fuzzing is better fuzzing. |
maflcko
force-pushed
the
2004-testLogExtraArgs
branch
from
f5d6a22 to
18a9987
Compare
maflcko
force-pushed
the
2004-testLogExtraArgs
branch
from
18a9987 to
faea0a9
Compare
Member
Author
|
Rebased now that #18615 is merged |
maflcko
force-pushed
the
2004-testLogExtraArgs
branch
from
faea0a9 to
fa69f88
Compare
Contributor
|
ACK fa69f88 -- patch looks correct |
Member
Author
|
I couldn't verify my claim that this speeds up fuzzing, but at least I am no longer running out of disk space, so I think it is still required. |
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 29, 2020
Summary: This will allow for the scheduler to be destructed even for tests that only use the `BasicTestingSetup`. This fixes a TSAN lock order inversion issue when running the `reverselock_tests` and the `scheduler_tests` together. Extracted from core [[bitcoin/bitcoin#18571 | PR18571]]. Test Plan: ./src/test/test_bitcoin -t reverselock_tests,scheduler_tests ninja check Reviewers: #bitcoin_abc, deadalnix, jasonbcox Reviewed By: #bitcoin_abc, deadalnix, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D6766
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 9, 2020
Summary:
```
There are several issues with writing to a debug log file when fuzzing:
Disk access is slow, but fuzzing should be fast (Note: I could not
verify this claim with data)
Disks have a limited size and will eventually run out of space, but
fuzzing should run continuous
Fix both issues by disabling the debug log file for fuzz tests
```
Backport of core [[bitcoin/bitcoin#18571 | PR18571]].
Depends on D8636.
Test Plan:
ninja all check
ninja bitcoin-fuzzers
./test/fuzz/test_runner.py <path_to_corpus>
Reviewers: #bitcoin_abc, deadalnix
Reviewed By: #bitcoin_abc, deadalnix
Differential Revision: https://reviews.bitcoinabc.org/D8637
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several issues with writing to a debug log file when fuzzing:
Fix both issues by disabling the debug log file for fuzz tests