gui: Fix leak in CoinControlDialog::updateView#18578
Merged
jonasschnelli merged 1 commit intobitcoin:masterfrom May 13, 2020
Merged
gui: Fix leak in CoinControlDialog::updateView#18578jonasschnelli merged 1 commit intobitcoin:masterfrom
jonasschnelli merged 1 commit intobitcoin:masterfrom
Conversation
promag
changed the title
Contributor
Author
|
@jonasschnelli friendly ping. |
Member
|
Concept ACK. |
Member
hebasto
reviewed
May 4, 2020
Member
hebasto
left a comment
hebasto
left a comment
There was a problem hiding this comment.
This constructor
bitcoin/src/qt/coincontroldialog.h
Line 34 in a3a02dd
promag
force-pushed
the
2020-fix-coincontroldialog-leak
branch
from
a3a02dd to
d8d9342
Compare
Contributor
Author
Member
Mind providing steps to reproduce? I've already tried to run Another suggestion: if this commit is related to #17457, maybe move it to #17457? |
Contributor
|
The first commit looks indeed after a memory leak fix. |
promag
force-pushed
the
2020-fix-coincontroldialog-leak
branch
from
d8d9342 to
e8123ea
Compare
Contributor
Author
|
@jonasschnelli @hebasto dropped f95ebe7 and rebased. |
luke-jr
approved these changes
May 5, 2020
Contributor
|
utACK e8123ea |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 14, 2020
e8123ea gui: Fix itemWalletAddress leak when not tree mode (João Barbosa) Pull request description: Taken from bitcoin#17457, the first commit is a similar to 88a94f7 but for test binary, and the second commit fixes a leak where `CCoinControlWidgetItem` are unnecessarily created and leaked. ACKs for top commit: jonasschnelli: utACK e8123ea hebasto: ACK e8123ea, tested on Linux Mint 19.3. Tree-SHA512: 8b43cb29de103842ce5f048de51222919540d3212d2873c16731145e856178644041924ad0e9a58c2ff08f209a9b4ac26dc9965289eb719da233c0984f93631e
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
May 15, 2020
Github-Pull: bitcoin#18578 Rebased-From: e8123ea
maflcko
pushed a commit
that referenced
this pull request
May 15, 2020
245c862 test: disable script fuzz tests (fanquake) 9a8fb4c fuzz: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer (practicalswift) 6161c94 [net processing] Only send a getheaders for one block in an INV (John Newbery) cf2a6e2 test: Remove const to work around compiler error on xenial (Wladimir J. van der Laan) cc7d344 miner: Avoid stack-use-after-return in validationinterface (MarcoFalke) 37a6207 test: Add unregister_validation_interface_race test (MarcoFalke) ff4dc20 gui: Fix manual coin control with multiple wallets loaded (João Barbosa) ed0afe8 test: Add test for conflicted wallet tx notifications (Russell Yanofsky) 251e321 rpc: Relock wallet only if most recent callback (João Barbosa) ca4dac4 rpc: Add mutex to guard deadlineTimers (João Barbosa) a3fe458 [docs] Improve commenting in ProcessGetData() (John Newbery) 011532e [test] test that an invalid GETDATA doesn't prevent processing of future messages (Amiti Uttarwar) 1e73d72 [net processing] ignore unknown INV types in GETDATA messages (Amiti Uttarwar) fb82173 [net processing] ignore tx GETDATA from blocks-only peers (Amiti Uttarwar) 315ae14 gui: Fix itemWalletAddress leak when not tree mode (João Barbosa) Pull request description: Backports the following PRs to the 0.20 branch: * #18578: gui: Fix leak in CoinControlDialog::updateView * #18808: [net processing] Drop unknown types in getdata * #18814: rpc: Relock wallet only if most recent callback * #18878: test: Add test for conflicted wallet tx notifications * #18894: gui: Fix manual coin control with multiple wallets loaded * #18742: miner: Avoid stack-use-after-return in validationinterface * #18962: net processing: Only send a getheaders for one block in an INV * #18975: test: Remove const to work around compiler error on xenial ACKs for top commit: promag: Tested ACK 245c862 coin control with multiple wallets. laanwj: ACK 245c862 MarcoFalke: ACK 245c862 solved the conflicts myself as a sanity check. Did not re-review 🍷 Tree-SHA512: 285e5a5fad5bbeba6032742c65dc68836e8eccfcceda9e69fec4ddd162a3f61679a96f9bbe3d434267835af67c21ac4c05accf6f63e827c2eb47203c6daafe31
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Nov 7, 2020
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 28, 2021
Summary: This is a backport of Core [[bitcoin/bitcoin#18578 | PR18578]] Test Plan: `ninja && src/qt/bitcoin-qt` In the Send tab, click the "Inputs" button, select "Tree mode". Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D9097
backpacker69
referenced
this pull request
in peercoin/peercoin
Mar 28, 2021
Github-Pull: #18578 Rebased-From: e8123ea
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
e8123ea gui: Fix itemWalletAddress leak when not tree mode (João Barbosa) Pull request description: Taken from bitcoin#17457, the first commit is a similar to 88a94f7 but for test binary, and the second commit fixes a leak where `CCoinControlWidgetItem` are unnecessarily created and leaked. ACKs for top commit: jonasschnelli: utACK e8123ea hebasto: ACK e8123ea, tested on Linux Mint 19.3. Tree-SHA512: 8b43cb29de103842ce5f048de51222919540d3212d2873c16731145e856178644041924ad0e9a58c2ff08f209a9b4ac26dc9965289eb719da233c0984f93631e
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 15, 2021
e8123ea gui: Fix itemWalletAddress leak when not tree mode (João Barbosa) Pull request description: Taken from bitcoin#17457, the first commit is a similar to 88a94f7 but for test binary, and the second commit fixes a leak where `CCoinControlWidgetItem` are unnecessarily created and leaked. ACKs for top commit: jonasschnelli: utACK e8123ea hebasto: ACK e8123ea, tested on Linux Mint 19.3. Tree-SHA512: 8b43cb29de103842ce5f048de51222919540d3212d2873c16731145e856178644041924ad0e9a58c2ff08f209a9b4ac26dc9965289eb719da233c0984f93631e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taken from #17457, the first commit is a similar to 88a94f7 but for test binary, and the second commit fixes a leak where
CCoinControlWidgetItemare unnecessarily created and leaked.