[doc] Update thread information in developer docs#18645
Merged
maflcko merged 1 commit intobitcoin:masterfrom Apr 15, 2020
Merged
[doc] Update thread information in developer docs#18645maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Contributor
jnewbery
commented
Apr 15, 2020
jnewbery
commented
- DumpAddresses thread was removed in Lightweight task scheduler #5964
- Shutdown thread was removed in Get rid of DetectShutdownThread #5679
- Add new threads (scheduler, RPC worker, indexer, tor control)
- Small changes to documentation of other threads
Contributor
|
Thanks. Glad someone takes care of this. Such documentations do quickly outdate. |
Member
|
Concept ACK. Maybe add thread names that are available via tools like |
maflcko
reviewed
Apr 15, 2020
jnewbery
force-pushed
the
2020-04-doc-threads
branch
from
04c466a to
c91fba7
Compare
Contributor
Author
Done
Done |
Contributor
|
ACK c91fba7 |
maflcko
reviewed
Apr 15, 2020
maflcko
reviewed
Apr 15, 2020
maflcko
reviewed
Apr 15, 2020
Member
|
ACK c91fba7f60b129387fe7ccabb93f28601de80e68 , except for the wrong links |
jnewbery
force-pushed
the
2020-04-doc-threads
branch
from
509ed8d to
66e67cf
Compare
Contributor
Author
|
Thanks @MarcoFalke. I've taken your changes. |
Member
|
ACK 66e67cfae16fd9154514b5d72888ceb49d52f390 only clicked the links, didn't read the comments |
hebasto
reviewed
Apr 15, 2020
hebasto
reviewed
Apr 15, 2020
jnewbery
force-pushed
the
2020-04-doc-threads
branch
from
66e67cf to
808ef36
Compare
Contributor
Author
|
Thanks for the review @hebasto . I've fixed your review comments. |
hebasto
approved these changes
Apr 15, 2020
Member
|
ACK 808ef36 |
jonatack
reviewed
Apr 15, 2020
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK. Nice idea to add the doxygen links.
|
|
||
| - ThreadRPCServer : Remote procedure call handler, listens on port 8332 for connections and services them. | ||
| - [ThreadMessageHandler (`b-msghand`)](https://doxygen.bitcoincore.org/class_c_connman.html#aacdbb7148575a31bb33bc345e2bf22a9) | ||
| : Application level message handling (sending and receiving). Almost |
Member
There was a problem hiding this comment.
s/Application level/Application-level/
| : Universal plug-and-play startup/shutdown. | ||
|
|
||
| - [ThreadSocketHandler (`b-net`)](https://doxygen.bitcoincore.org/class_c_connman.html#a765597cbfe99c083d8fa3d61bb464e34) | ||
| : Sends/Receives data from peers on port 8333. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 16, 2020
808ef36 [doc] Update thread information in developer docs (John Newbery) Pull request description: - DumpAddresses thread was removed in bitcoin#5964 - Shutdown thread was removed in bitcoin#5679 - Add new threads (scheduler, RPC worker, indexer, tor control) - Small changes to documentation of other threads ACKs for top commit: MarcoFalke: ACK 808ef36 hebasto: ACK 808ef36. Tree-SHA512: 85b6ace7bcc4dee030c63461bef1ded1a9581d4fa249c59f6fcd5d33d89c4357a6b8b35888ce0960f276d397b5e38a21e6c5d4b7b79544827a28c950e097b36d
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 15, 2021
Summary: This is a backport of Core [[bitcoin/bitcoin#18645 | PR18645]] Note: the StartNode line was removed in [[bitcoin/bitcoin#17539 | PR17539]] (not yet backported) Test Plan: Clicked on all the URLs to check that they work. Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8930
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.