gui: Add a Make unsigned button next to Send#18656
Closed
achow101 wants to merge 1 commit intobitcoin:masterfrom
Closed
gui: Add a Make unsigned button next to Send#18656achow101 wants to merge 1 commit intobitcoin:masterfrom
Make unsigned button next to Send#18656achow101 wants to merge 1 commit intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 16, 2020
achow101
force-pushed
the
make-unsigned-button
branch
from
2474e98 to
5f80564
Compare
Instead of changing Send to make an unsigned tx for wallets with private keys disabled, have a separate button for that functionality and disable Send for such wallets.
achow101
force-pushed
the
make-unsigned-button
branch
from
5f80564 to
0acaefa
Compare
Member
|
This would likely confuse users as-is. Can we simplify the workflow so it always makes a PSBT, but in a way that users can easily sign+broadcast? Perhaps the PSBT dialog can become like the current send confirmation dialog unless an expert-mode option is enabled? |
Member
|
I think sticking this behind an expert mode switch is probably the right thing to do at a minimum. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having the Send button mutate into a Create Unsigned button when
IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS), have a second button that always creates a psbt. The original Send button will then not change its behavior and just disable itself when private keys are disabled.#17509 does a refactor that makes this easier, so this PR is dependent on that.
Split from #18627