GUI: Enable changing the autoprune block space size in intro dialog#18728
Closed
luke-jr wants to merge 4 commits intobitcoin:masterfrom
Closed
GUI: Enable changing the autoprune block space size in intro dialog#18728luke-jr wants to merge 4 commits intobitcoin:masterfrom
luke-jr wants to merge 4 commits intobitcoin:masterfrom
Conversation
luke-jr
force-pushed
the
intro_prune_size
branch
from
9352dd6 to
4f00890
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Contributor
|
some screenshots might be handy @luke-jr |
luke-jr
force-pushed
the
intro_prune_size
branch
from
4f00890 to
7d40a48
Compare
Member
Author
|
Rebased, screenshot added to OP |
Member
|
Given this hasn't received any review/discussion in the 5 months since opening, and is entirely in GUI code, let's move this PR over to the GUI repo. |
hebasto
added a commit
to bitcoin-core/gui
that referenced
this pull request
Apr 29, 2021
…ialog 415fb2e GUI/Intro: Move prune setting below explanation (Luke Dashjr) 2a84c6b GUI/Intro: Estimate max age of backups that can be restored with pruning (Luke Dashjr) e2dcd95 GUI/Intro: Rework UI flow to let the user set prune size in GBs (Luke Dashjr) f2e5a6b GUI/Intro: Abstract GUI-to-option into Intro::getPrune (Luke Dashjr) 62932cc GUI/Intro: Return actual prune setting from showIfNeeded (Luke Dashjr) Pull request description:  Moved from bitcoin/bitcoin#18728 ACKs for top commit: ryanofsky: Code review ACK 415fb2e. Changes since last review: mb/gib suffixes, constexpr QOverload expected_backup_days tweaks, new moveonly layout commit jarolrod: Tested ACK 415fb2e. Talkless: tACK 415fb2e, tested on Debian Sid with Qt 5.15.2. hebasto: ACK 415fb2e, my unresolved comments are not blockers, and they could be resolved in follow ups. Tree-SHA512: bd4882a9c08e6a6eb14b7fb6366983db8581425b4949fea212785d34d8fad9e32fb81ca8c8cdbfb2c05ea394aaf5a746ba2cf16623795c7252c3bdb61d455f00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.