refactor: Make CCheckQueue RAII-styled#18731
Closed
hebasto wants to merge 7 commits intobitcoin:masterfrom
Closed
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 22, 2020
hebasto
changed the title
promag
reviewed
Apr 26, 2020
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Concept ACK RAII style.
Need to fix test/fuzz/checkqueue.cpp in lines 41 and 42.
hebasto
force-pushed
the
200421-queue-raii
branch
from
ba61343 to
3553bde
Compare
hebasto
changed the title
Member
Author
|
Rebased ba61343 -> 3553bde (pr18731.01 -> pr18731.02) |
hebasto
changed the title
hebasto
force-pushed
the
200421-queue-raii
branch
2 times, most recently
from
ac16422 to
01be64d
Compare
Member
Author
|
Updated 3553bde -> 01be64d (pr18731.02 -> pr18731.04, diff):
And this PR is ready for review, finally. |
hebasto
changed the title
This was referenced May 2, 2020
Closed
8 tasks
hebasto
force-pushed
the
200421-queue-raii
branch
from
01be64d to
3fa8587
Compare
Also this commits gets rid of scriptcheckqueue global variable.
hebasto
force-pushed
the
200421-queue-raii
branch
from
e5a82de to
56d40da
Compare
Member
Author
|
Rebased e5a82de -> 56d40da (pr18731.14 -> pr18731.15) due to the conflict with #19927. |
This was referenced Sep 28, 2020
12 tasks
This was referenced Oct 23, 2020
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Contributor
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
1 similar comment
Contributor
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
Member
|
#18710 was merged, so this could be rebased and brought out of draft if you are still working on this. |
Member
Author
|
I won't be able to focus on this stuff in the near future. So closing up for grabs. |
Member
Author
|
achow101
added a commit
that referenced
this pull request
Nov 30, 2023
5b3ea5f refactor: Move `{MAX,DEFAULT}_SCRIPTCHECK_THREADS` constants (Hennadii Stepanov) 6e17b31 refactor: Make `CCheckQueue` non-copyable and non-movable explicitly (Hennadii Stepanov) 8111e74 refactor: Drop unneeded declaration (Hennadii Stepanov) 9cf89f7 refactor: Make `CCheckQueue` constructor start worker threads (Hennadii Stepanov) d03eaac Make `CCheckQueue` destructor stop worker threads (Hennadii Stepanov) be4ff30 Move global `scriptcheckqueue` into `ChainstateManager` class (Hennadii Stepanov) Pull request description: This PR: - makes `CCheckQueue` RAII-styled - gets rid of the global `scriptcheckqueue` - fixes #25448 The previous attempt was in #18731. ACKs for top commit: martinus: ACK 5b3ea5f achow101: ACK 5b3ea5f TheCharlatan: ACK 5b3ea5f Tree-SHA512: 45cca846e7ed107e3930149f0b616ddbaf2648d6cde381f815331b861b5d67ab39e154883ae174b8abb1dae485bc904318c50c51e5d6b46923d89de51c5eadb0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
CCheckQueueRAII-styledscriptcheckqueueg_parallel_script_checksThis PR is based on #18710, therefore only the last two commits should be considered.