Bugfix: Only use git for build info if the repository is actually the right one#18902
Bugfix: Only use git for build info if the repository is actually the right one#18902luke-jr wants to merge 4 commits intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
DrahtBot
added
Needs rebase
and removed
Needs gitian build
DrahtBot Guix build requested
labels
… right one Original-Github-Pull: bitcoin#7522 Rebased-From: e98e3dd e98e3dd Github-Pull: bitcoin#18902 Rebased-From: d9505bb
Github-Pull: bitcoin#18902 Rebased-From: 83ecd1b
luke-jr
force-pushed
the
fix_gitdir_again
branch
from
83ecd1b to
98e497f
Compare
… right one Original-Github-Pull: bitcoin#7522 Rebased-From: e98e3dd e98e3dd
luke-jr
force-pushed
the
fix_gitdir_again
branch
from
98e497f to
e09ae11
Compare
luke-jr
force-pushed
the
fix_gitdir_again
branch
2 times, most recently
from
f104c23 to
e09ae11
Compare
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
Closing for now. This needs rebase and there hasn't been any activity for months. You can leave a comment if you want this to be reopened. (Or create a new pull, since there haven't been any comments here). Though, please make sure the code is passing tests and is ready for review. |
4 participants
Fixes using unrelated git repos again, after the fix in #7522 was unexplicably removed by #18556
Also (really) fixes the "build version hack" (#18349) by embedding the correct tag in the release
genbuild.shBased on top of #18818 to avoid unnecessary conflicts/rebasing once that's merged