qt: Add missing QPainterPath include#19097
Merged
fanquake merged 1 commit intobitcoin:masterfrom May 29, 2020
Merged
Conversation
This is needed to compile with Qt 5.15.
Member
|
Code review ACK 79b0a69 |
Member
|
Code review ACK 79b0a69 |
Contributor
|
Code review ACK 79b0a69. nit, could also forward declare in src/qt/trafficgraphwidget.h. |
Contributor
should be in the h file as it's already used there |
Contributor
|
Definition isn't necessary in the header, forward declaration is enough. |
Contributor
|
but what's the benefit, instead of directly including it in the h file? would actually save one line of code ;) |
Contributor
|
It's usually best practice to just include an header when the definition is required to minimize the compiler work. |
Contributor
|
makes sense |
luke-jr
pushed a commit
to luke-jr/bitcoin
that referenced
this pull request
Jun 4, 2020
This is needed to compile with Qt 5.15. Github-Pull: bitcoin#19097 Rebased-From: 79b0a69
maflcko
pushed a commit
that referenced
this pull request
Jun 4, 2020
384d3f9 Add missing QPainterPath include (Andrew Chow) Pull request description: This is needed to compile with Qt 5.15. Github-Pull: #19097 Rebased-From: 79b0a69 Top commit has no ACKs. Tree-SHA512: 23c4604cddb0bf5955afa6dfb6be87989df591e5f5ca5b85257c72e916f29337012b24c9ab5374a3289700ab7518ddb48f21195a2173ea1f935d69bd2ad13b8b
This was referenced Jun 7, 2020
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jul 15, 2020
This is needed to compile with Qt 5.15. Github-Pull: bitcoin#19097 Rebased-From: 79b0a69
Merged
maflcko
pushed a commit
that referenced
this pull request
Aug 11, 2020
be95147 Updated appveyor job to checkout a specific vcpkg commit ID. (Aaron Clauson) 1fd9cd2 appveyor: Remove clcache (MarcoFalke) 8c0a959 Remove cached directories and associated script blocks from appveyor CI configuration. (Aaron Clauson) d70f700 lint: fix shellcheck URL in CI install (fanquake) f8f7d91 test: remove Cirrus CI FreeBSD job (fanquake) b7e16a8 Add missing QPainterPath include (Andrew Chow) 30a2814 gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged (João Barbosa) 0d87a5b QA: feature_segwit: Check that template "rules" includes "!segwit" as appropriate (Luke Dashjr) bde6a5a Bugfix: Include "csv","!segwit" in "rules" (Luke Dashjr) e422f65 build: Set libevent minimum version to 2.0.21 (Hennadii Stepanov) 0d0dd6a Update with new Windows code signing certificate (Andrew Chow) Pull request description: Backports the following to the 0.19 branch: * #17946 - Fix GBT: Restore "!segwit" and "csv" to "rules" key * #18160 - gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged * #18425 - releases: Update with new Windows code signing certificate * #18676 - build: Check libevent minimum version in configure script * #19097 - qt: Add missing QPainterPath include (as per #19510) * #18640 - appveyor: Remove clcache * #19444 - test: Remove cached directories and associated script blocks from appveyor config * #19612 - lint: fix shellcheck URL in CI install * #18001 - Updated appveyor job to checkout a specific vcpkg commit ID Closes: #19510. ACKs for top commit: jnewbery: ACK be95147 MarcoFalke: cherry-pick ACK be95147 🌎 Tree-SHA512: 2ec7e3ae1da99799ff6f8cfe26095d6885cffe6952b18a7e236dc5e657b3918225c2601b8c8e17cdff5319c40cb0a214d9fad49b0ff2f54af1db7c81d83a1df5
Closed
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Oct 21, 2020
This is needed to compile with Qt 5.15. Github-Pull: bitcoin#19097 Rebased-From: 79b0a69
Platinumwrist
referenced
this pull request
in syscoin/syscoin
Oct 25, 2020
buzzkillb
added a commit
to buzzkillb/denarius
that referenced
this pull request
Dec 5, 2020
To compile with newer QT. bitcoin/bitcoin#19097
blockstreamsatellite
pushed a commit
to Blockstream/bitcoinsatellite
that referenced
this pull request
Jan 29, 2021
This is needed to compile with Qt 5.15. Github-Pull: bitcoin#19097 Rebased-From: 79b0a69
backpacker69
referenced
this pull request
in peercoin/peercoin
Mar 28, 2021
This is needed to compile with Qt 5.15. Github-Pull: #19097 Rebased-From: 79b0a69
This was referenced Jun 5, 2021
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
79b0a69 Add missing QPainterPath include (Andrew Chow) Pull request description: This is needed to compile with Qt 5.15. ACKs for top commit: laanwj: Code review ACK 79b0a69 MarcoFalke: Code review ACK 79b0a69 promag: Code review ACK 79b0a69. Tree-SHA512: 8dbc3fa4572ad9cacd72e9664926729947681b8ed4f4a0607e27e6389eb95c8b49e6883ae8dbdea7edbbfea267b4520c4844897a7b67f55f4b988b9feb689e60
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 15, 2021
79b0a69 Add missing QPainterPath include (Andrew Chow) Pull request description: This is needed to compile with Qt 5.15. ACKs for top commit: laanwj: Code review ACK 79b0a69 MarcoFalke: Code review ACK 79b0a69 promag: Code review ACK 79b0a69. Tree-SHA512: 8dbc3fa4572ad9cacd72e9664926729947681b8ed4f4a0607e27e6389eb95c8b49e6883ae8dbdea7edbbfea267b4520c4844897a7b67f55f4b988b9feb689e60
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed to compile with Qt 5.15.