util: Get rid of RecursiveMutex in Get{Blocks,Data}Dir#19213
util: Get rid of RecursiveMutex in Get{Blocks,Data}Dir#19213hebasto wants to merge 2 commits intobitcoin:masterfrom
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
hebasto
force-pushed
the
200608-path-mx
branch
from
f7f41a0 to
0173e68
Compare
hebasto
changed the title
|
Reworked without introducing a new helper function. ping @vasild @promag @MarcoFalke |
vasild
left a comment
vasild
left a comment
There was a problem hiding this comment.
Looks good.
The commit message reads just
util: Get rid of RecursiveMutex in Get{Blocks,Data}Dir
maybe it would be good to explain that we remove the recursive mutex by splitting it to two mutexes and ensuring they are always acquired in the same order.
This change removes the RecursiveMutex object by splitting it into two Mutex objects, and ensuring they are always acquired in the same order.
-BEGIN VERIFY SCRIPT- sed -i 's/pathCachedNetSpecific/g_datadir_path_cached_net_specific/' src/util/system.cpp sed -i 's/pathCached/g_datadir_path_cached/' src/util/system.cpp -END VERIFY SCRIPT-
hebasto
force-pushed
the
200608-path-mx
branch
from
0173e68 to
7b90f77
Compare
|
Updated 0173e68 -> 7b90f77 (pr19213.02 -> pr19213.03, diff):
|
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
Why close? |
It is incompatible with #21244. |
3 participants
Another step on the way to replacing all of the
RecursiveMutexinstances with theMutexones.This PR removes the
RecursiveMutexobject by splitting it into twoMutexobjects, and ensuring they are always acquired in the same order.Related to #19303.