ACK

Concept ACK on removing unused code

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

This is based on a 2018 base commit. Needs to be rebased to pick up all of the new tests/changes since then.

Code looks safe, but should be rebased on a recent base commit to ensure all new tests/checks run successfully.

Should https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki#getblocktemplate-changes be updated to say that maxversion no longer has meaning?

but should be rebased on a recent base commit to ensure all new tests/checks run successfully.

Agree. This branch is currently based off (8a9ffec).

Should https://github.com/bitcoin/bips/blob/master/bip-0009.mediawiki#getblocktemplate-changes be updated to say that maxversion no longer has meaning?

This also still needs a response.

Added "Waiting for author".

Rebased due to conflicts, but note

Code looks safe, but should be rebased on a recent base commit to ensure all new tests/checks run successfully.

That's not a reason to rebase. That's a flaw in QA infra. It should be merging to master before running tests/checks.

Concept ACK

That's not a reason to rebase. That's a flaw in QA infra.

There's a myriad of reasons to keep development branches rebased up and/or up to date.

If I'm a dev wanting to just simply checkout and test this code, i.e git fetch origin pull/19391/head:19391 && git checkout 19391, not only should I not have to worry about merging it into master myself, but, having a commit here based on a branch from years ago means it's going to bust up my caches when compiling, have missing tests, lack support for fuzzers & other tooling that's been added in the interim, depends will be outdated, so if I'm building against that I'll be testing against old / potentially broken dependencies. I also shouldn't need to replicate the QA infra locally to test things fairly extensively.

going to bust up my caches

Personally I rebase/merge every change I test on master (even if it is just a single commit back) to rule out any unintended cache mishaps and at the same time check for silent merge conflict.

If there is no reason to rebase, I think the approach @luke-jr is taking seems fine.

Concept ACK

Added to the 24.0 milestone.

@luke-jr do you want to rebase this, otherwise I can drop it back off the milestone.

#25153 should really have been reverted, but rebased anyway.

ACK 90a5dfa