Refactor mempool.dat to be extensible, and store missing info#19488
Closed
luke-jr wants to merge 2 commits intobitcoin:masterfrom
Closed
Refactor mempool.dat to be extensible, and store missing info#19488luke-jr wants to merge 2 commits intobitcoin:masterfrom
luke-jr wants to merge 2 commits intobitcoin:masterfrom
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jul 11, 2020
2 tasks
c86e067 to
1befffc
Compare
Contributor
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
Member
Author
|
This missed 0.21, so probably no point in continuing further for now... Can reopen later when/if it becomes relevant again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased #9422
At the time, we decided it wasn't worth the effort to just store the mempool min fee, but now we want to add unbroadcast txids (#18807) so it seems like a good time to upgrade the format to be extensible.
TODO: Update or remove
test/functional/mempool_compatibility.py(not clear how to handle this)