wallet: Fix clang build in Mac#19493
Merged
maflcko merged 1 commit intobitcoin:masterfrom Jul 11, 2020
bvbfan:mac_fix
Merged
Conversation
Signed-off-by: Anthony Fieroni <[email protected]>
Contributor
Author
|
It fixes clang build in MacOS |
Member
|
I think I ran into that error as well, thanks for the fix. |
luke-jr
pushed a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Aug 15, 2020
Signed-off-by: Anthony Fieroni <[email protected]> Github-Pull: bitcoin#19493 Rebased-From: 1e58bcc
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 31, 2021
Summary: PR18850: > The motivation is mapWallet is used, in many places, without check (method at expects that hash presents) but that's not exactly true when mapTxSpends and mapWallet are out of sync. That can lead to crash/data loss in wallet. PR19493 fixes clang build on Mac OS This is a backport of [[bitcoin/bitcoin#18850 | core#18850]] and [[bitcoin/bitcoin#19493 | core#19493]] Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D9989
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anthony Fieroni [email protected]