tests: add sync_all to fix race condition in wallet groups test#19756
Merged
maflcko merged 1 commit intobitcoin:masterfrom Aug 18, 2020
Merged
tests: add sync_all to fix race condition in wallet groups test#19756maflcko merged 1 commit intobitcoin:masterfrom
maflcko merged 1 commit intobitcoin:masterfrom
Conversation
Merged
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 18, 2020
…let groups test 72ae20f tests: add sync_all to fix race condition in wallet groups test (Karl-Johan Alm) Pull request description: This most likely fixes bitcoin#19749, the intermittent CI issues with wallet_groups. This fix is also included in bitcoin#19743. Top commit has no ACKs. Tree-SHA512: dd6ef7f89829483e2278191c21fe0912b51fd2187c10a0fa158339c5ab9f22d93b733ae10f17ef25d8b64f44e596e66dba8d7db5c009343472f422ce4cd67d8f
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 8, 2020
…ups test Summary: 72ae20fc142457a200278cb2fedc5e32a3766b58 tests: add sync_all to fix race condition in wallet groups test (Karl-Johan Alm) Pull request description: This most likely fixes #19749, the intermittent CI issues with wallet_groups. This fix is also included in #19743. Backport of Core [[bitcoin/bitcoin#19756 | PR19756]] We're seeing increased flakiness for this test in our sanitizer builds. This should fix it. Test Plan: `./test/functional/test_runner.py wallet_groups` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7826
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This most likely fixes #19749, the intermittent CI issues with wallet_groups.
This fix is also included in #19743.